Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): Make submission template configurable #3425

Merged
merged 10 commits into from
Dec 12, 2024
Merged

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 11, 2024

resolves #3331

preview URL: http://submission-template.loculus.org

Summary

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fhennig fhennig added the preview Triggers a deployment to argocd label Dec 11, 2024
@fhennig fhennig marked this pull request as draft December 11, 2024 10:25
@chaoran-chen
Copy link
Member

maybe validate that the fields exist?

The fields don't need to be the same as the fields that LAPIS receives and the backend cares about, so at the moment, I don't think that there is much to validate.

@fhennig
Copy link
Contributor Author

fhennig commented Dec 11, 2024

I'm validating that the fields are part of the inputFields 03f4267 (#3425) (Theo told me about this)

i think just docs i missing and then this is done.

I've adapted the existing tests so there is test coverage too.

@fhennig fhennig self-assigned this Dec 11, 2024
@fhennig fhennig marked this pull request as ready for review December 11, 2024 13:03
@fhennig fhennig requested a review from chaoran-chen December 11, 2024 13:17
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@fhennig fhennig enabled auto-merge (squash) December 12, 2024 12:52
@fhennig fhennig disabled auto-merge December 12, 2024 12:56
@fhennig fhennig merged commit d3505b7 into main Dec 12, 2024
20 checks passed
@fhennig fhennig deleted the submission-template branch December 12, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submission template: have a subset of fields in template
3 participants