Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): specify width for column(s) in search table #3353

Merged
merged 24 commits into from
Dec 3, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Dec 3, 2024

resolves #3343

preview URL: https://colwidths2.loculus.org/ebola-sudan/search?

Summary

Allows specifying column widths (which are actual minimum widths). If a column has no set width, behaviour is unchanged from pre-existing situation.

I haven't added too many for Loculus as this doesn't transfer across to our real deployments.

Screenshot

Before:
image

After:
image

@theosanderson theosanderson added the preview Triggers a deployment to argocd label Dec 3, 2024
@theosanderson theosanderson added the format_me Triggers github_actions to format website code on PR label Dec 3, 2024
@theosanderson theosanderson changed the title Colwidths2 feat(website): specify width for column(s) in search table Dec 3, 2024
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good but just a few minor comments.

@theosanderson theosanderson merged commit 5b3bf02 into main Dec 3, 2024
20 checks passed
@theosanderson theosanderson deleted the colwidths2 branch December 3, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_me Triggers github_actions to format website code on PR preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customizable column widths
2 participants