feat(website): Change data use terms in bulk

[fhennig]

resolves #992

preview URL: http://datausetermsbulkchange.loculus.org

Summary

• new EditDataUseTermsModal
  • Has 3 different variants, depending on if all selected sequences are OPEN, all RESTRICTED or a mix of both.
  • Displayed only in the 'View your group's released' page
  • fetches data from LAPIS and updates it in the backend
• Refactored
  • The DateTimePicker is now part of the DataUseTermsSelector component and has been pulled out of the submission form and EditDataUseTermsButton. The DataUseTermsSelector has a setting to switch between an inline and dialog DateTimePicker.
  • The new EditDateUseTermsModal and the DownloadDialog use a common BaseDialog component.
  • The DownloadParameters union type has been refactored into a SequenceFilter that is now also used by the new modal to get the LAPIS query parameters it needs. Various code spread around components has been factored into methods of the new classes.
• Add a test for the new extended DataUseTermsSelector

Screenshot

There are 3 different types of panels, depending on the selection of sequences. below is the one for when only restricted sequences are selected:

PR Checklist

• All necessary documentation has been adapted. (not applicable?)
• The implemented feature is covered by an appropriate test. (The DataUseTermsSelector is tested, and then simply emebedded in the new modal. That seemed sufficient to me)

[corneliusroemer]

This is the test that failed:

1 failed
    [chromium] › pages/search/index.spec.ts:61:5 › The search page › should search many sequence entries by accession 
  1 flaky

  1) [chromium] › pages/search/index.spec.ts:61:5 › The search page › should search many sequence entries by accession 

    Error: expect(received).toBeTruthy()

    Received: false

      74 |         expect(newAccessions.length).toBe(3);
      75 |         expect(newAccessions.includes(previousAccessions[0])).toBeTruthy();
    > 76 |         expect(newAccessions.includes(previousAccessions[1])).toBeTruthy();
         |                                                               ^
      77 |         expect(newAccessions.includes(previousAccessions[2])).toBeTruthy();
      78 |     });
      79 |
        at /home/runner/work/loculus/loculus/website/tests/pages/search/index.spec.ts:76:63

[theosanderson]

Really good work, I had a look through all the code and it looks great to my eyes

[fhennig]

Some more feedback I got from @corneliusroemer

• The two column open/restricted selector doesn't look good on mobile (-> maybe make the layout responsive)
• One can apply a "non-update" and it shows in the data use terms history (should just not update)
• There is an error message "Please chose a date before ..." (see image below) and it should say "before or equal to", because once can 'equalize' the dates on multiple sequences.

Image with the error message

Thanks Theo and Cornelius for the review!!

[theosanderson]

To my mind we don't need to worry that much about mobile responsivity for submission-related pages (but ofc. no problem with making it better if that's not too hard)

[fhennig]

regarding "One can apply a "non-update" and it shows in the data use terms history"

I implemented a fix here: d2e5503 (#3322)

It wasn't possible to do the filtering in the backend without breaking up the batchInsert into individual inserts, and so I decided to calculate the affected accessions in the frontend. This is actually cool, because now the number on the button shows correctly how many sequences actually receive a changed date!

[theosanderson]

I didn't look through all the code again, but functionality seems good now and we've had a pass through the code so I'm approving. Thanks for all the hard work!