-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest): Use augur curate to curate country metadata #3015
Draft
anna-parker
wants to merge
36
commits into
main
Choose a base branch
from
add_country_metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+705
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cornelius Roemer <[email protected]>
Co-authored-by: Cornelius Roemer <[email protected]>
…ata from NCBI Virus (#2990) * Use raw jsonl instead of generated tsv when ingesting data from NCBI virus * Do not require authors list to end in ';', capitalize names correctly. * Add tests for capitalization * Add a warning if author list might be in wrong format * Add ascii specific warning * Add tests for warnings and errors * Only capitalize if full authors string is upper case * Properly capitalize initial * Move titlecase option to ingest only - add ingest tests
anna-parker
changed the title
Add_country_metadata
feat(ingest): Use augur curate to curate country metadata
Oct 17, 2024
corneliusroemer
force-pushed
the
format_authors
branch
from
October 18, 2024 14:47
9c89328
to
533f051
Compare
corneliusroemer
force-pushed
the
format_authors
branch
from
October 18, 2024 14:58
533f051
to
f480d67
Compare
anna-parker
force-pushed
the
format_authors
branch
2 times, most recently
from
October 22, 2024 09:38
c3cb79c
to
6e05226
Compare
anna-parker
force-pushed
the
format_authors
branch
from
October 25, 2024 16:11
8fc0a47
to
0f60fd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
preview URL: https://add-country-metadata.loculus.org/
Summary
Prompted by work in #2991, this uses augur curate for formatting.
Screenshot
PR Checklist