Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

[Feature]: Test and tune velocity PID, steering pid and pure persuit controller #151

Open
Julian-Graf opened this issue Jan 11, 2023 · 0 comments
Assignees
Labels

Comments

@Julian-Graf
Copy link
Contributor

Julian-Graf commented Jan 11, 2023

Description

Test and tune velocity PID, steering pid and pure persuit controller

Definition of Done

  • control deviation is low
  • velocity is never higher than given max_velocity
@Julian-Graf Julian-Graf changed the title [Feature]: Tune velocity PID [Feature]: Test and tune velocity PID, steering pid and pure persuit controller Jan 25, 2023
JoKircher added a commit that referenced this issue Feb 27, 2023
# Description

Implementation of the stanley controller. With the testing conducted, I
am confident, that basically all errors have been fixed.
Obviously tuning is still very much needed (#151). Due to a botched
rebase, i created a second branch for this issue and transferred the
previous progress, this should also reduces merge conflicts.

Fixes #66 

## Time invested

- 12 h @schwalga 

## Type of change

- New feature (non-breaking change which adds functionality)

## Does this PR introduce a breaking change?

no

## Most important changes

stanley_controller.py plus some additional fixes in basic helper
functions.

# Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works (might be obsolete with CI later on)
- [x] New and existing unit tests pass locally with my changes (might be
obsolete with CI later on)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants