Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stac-validate-collections retries should be managed by tpl-at-stac-validate only TDE-1178 #585

Conversation

paulfouquet
Copy link
Collaborator

Motivation

In the case of a task in tpl-at-stac-validate fails more than twice and the workflow came back failing, the entire stac-validate-collections is retried twice which cause to run the inner stac-validate workflow.

Modification

Avoid tasks in the stac-validate-parallel workflow to retry by default.
Force aws-list-collections to retry twice if it fails.
This is a work around as I could not find a way to specify the retryStrategy at a task level using a templateRef

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@paulfouquet paulfouquet requested review from a team as code owners May 15, 2024 03:41
@paulfouquet paulfouquet changed the title fix: stac-validate-collections retries should be managed by tp-at-stac-validate only TDE-1178 fix: stac-validate-collections retries should be managed by tpl-at-stac-validate only TDE-1178 May 15, 2024
Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PS: limit is defined as int or string, so we could use integers here.

@paulfouquet
Copy link
Collaborator Author

LGTM

PS: limit is defined as int or string, so we could use integers here.

Weirdly I've got this warning when I use a integer:
Incorrect type. Expected "string".yaml-schema: https://raw.githubusercontent.com/argoproj/argo-workflows/v3.5.5/api/jsonschema/schema.json

@paulfouquet paulfouquet added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit 0da70b2 May 15, 2024
4 checks passed
@paulfouquet paulfouquet deleted the fix/avoid-retrying-entire-stac-validate-if-fails-3-times-tde-1178 branch May 15, 2024 22:04
@l0b0
Copy link
Contributor

l0b0 commented May 15, 2024

Weirdly I've got this warning when I use a integer: Incorrect type. Expected "string".yaml-schema: https://raw.githubusercontent.com/argoproj/argo-workflows/v3.5.5/api/jsonschema/schema.json

    "io.k8s.apimachinery.pkg.util.intstr.IntOrString": {
      "type": "string"
    },

🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants