Skip to content

Commit

Permalink
fix: stac-validate-collections retries should be managed by tpl-at-st…
Browse files Browse the repository at this point in the history
…ac-validate only TDE-1178 (#585)

#### Motivation
In the case of a task in `tpl-at-stac-validate` fails more than twice
and the workflow came back failing, the entire
`stac-validate-collections` is retried twice which cause to run the
inner stac-validate workflow.

#### Modification

Avoid tasks in the `stac-validate-parallel` workflow to retry by
default.
Force `aws-list-collections` to retry twice if it fails.
This is a work around as I could not find a way to specify the
retryStrategy at a task level using a `templateRef`

#### Checklist

_If not applicable, provide explanation of why._

- [ ] Tests updated
- [ ] Docs updated
- [x] Issue linked in Title
  • Loading branch information
paulfouquet authored May 15, 2024
1 parent c4a6362 commit 0da70b2
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions workflows/stac/stac-validate-parallel.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ spec:
image: ''
templates:
- name: main
retryStrategy:
limit: '0' # avoid retrying any of the following task as `tpl-at-stac-validate` already retries its own tasks.
dag:
tasks:
- name: aws-list-collections
Expand All @@ -57,6 +59,8 @@ spec:
depends: aws-list-collections
withParam: '{{tasks.aws-list-collections.outputs.parameters.files}}'
- name: aws-list-collections
retryStrategy:
limit: '2' # force retrying this specific task
container:
image: '019359803926.dkr.ecr.ap-southeast-2.amazonaws.com/argo-tasks:{{=sprig.trim(workflow.parameters.version_argo_tasks)}}'
command: [node, /app/index.js]
Expand Down

0 comments on commit 0da70b2

Please sign in to comment.