Skip to content

Commit

Permalink
fix: pass compression as preset to tileindex-validate TDE-895 TDE-1151 (
Browse files Browse the repository at this point in the history
#546)

#### Motivation

We only want to check `webp` datasets are 8-bit so Argo Tasks
tileindex-validate needs to know the dataset type.

#### Modification

Pass the `compression` type of the dataset to Argo Tasks
tileindex-validate as `preset` for validation

#### Checklist

- [ ] Tests updated N/A
- [x] Docs updated
- [x] Issue linked in Title
  • Loading branch information
amfage authored Apr 18, 2024
1 parent 8022c8d commit 48ec916
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
5 changes: 5 additions & 0 deletions templates/argo-tasks/tile-index-validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ spec:
description: Output tile configuration for retiling
default: 'false'

- name: preset
description: Compression type of dataset e.g. webp, lzw, dem_lerc
default: 'webp'

- name: version
description: container version to use
default: 'v3'
Expand Down Expand Up @@ -78,6 +82,7 @@ spec:
- '--scale={{= inputs.parameters.scale }}'
- '--validate={{= inputs.parameters.validate }}'
- '--retile={{= inputs.parameters.retile }}'
- '--preset={{= inputs.parameters.compression }}'
- "{{= sprig.empty(inputs.parameters.source_epsg) ? '' : '--source-epsg=' + inputs.parameters.source_epsg }}"
- "{{= sprig.empty(inputs.parameters.include) ? '' : '--include=' + inputs.parameters.include }}"
- '{{= sprig.trim(inputs.parameters.source) }}'
Expand Down
2 changes: 1 addition & 1 deletion workflows/raster/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ If no input collection ID is provided a ULID is generated and used as the collec

### [tileindex-validate](https://github.com/linz/argo-tasks/blob/master/src/commands/tileindex-validate/)

Lists tiffs from source input, validates they match a LINZ Mapsheet tile index and asserts that there will be no duplicates.
Lists tiffs from source input, validates they match a LINZ Mapsheet tile index and asserts that there will be no duplicates. Checks `webp` files are 8-bit.

### [standardise-validate](https://github.com/linz/topo-imagery/blob/master/scripts/standardise_validate.py)

Expand Down
2 changes: 2 additions & 0 deletions workflows/raster/standardising.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,8 @@ spec:
value: '{{= workflow.parameters.validate}}'
- name: retile
value: '{{= workflow.parameters.retile}}'
- name: preset
value: '{{= workflow.parameters.compression}}'
- name: version
value: '{{= workflow.parameters.version_argo_tasks}}'

Expand Down

0 comments on commit 48ec916

Please sign in to comment.