Skip to content

Commit

Permalink
fix: node nodeAntiAffinity seems to break karpenter TDE-1112 BM-1018 (#…
Browse files Browse the repository at this point in the history
…545)

#### Motivation

We've noticed that karpenter is erroring since
#506. Errors makes us
thinking that it could be related. Since the retry on a new node using
`nodeAntiAffinity` [is not
working](argoproj/argo-workflows#12701), it's a
good idea to remove it to see if it solved `karpenter` issues.

#### Modification

Remove the `affinity` in the `retryStrategy`.

#### Checklist

- [ ] Tests updated
- [x] Docs updated
- [x] Issue linked in Title
  • Loading branch information
paulfouquet authored Apr 18, 2024
1 parent 43af2ea commit 8022c8d
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions infra/charts/argo.workflows.ts
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,10 @@ export class ArgoWorkflows extends Chart {
},
],
parallelism: 3,
// FIXME: `nodeAntiAffinity` - to retry on different node - is not working yet (https://github.com/argoproj/argo-workflows/pull/12701)
retryStrategy: { limit: 2, affinity: { nodeAntiAffinity: {} } },
/** TODO: `nodeAntiAffinity` - to retry on different node - is not working yet (https://github.com/argoproj/argo-workflows/pull/12701)
* `affinity: { nodeAntiAffinity: {} }` seems to break `karpenter`, need more investigation
*/
retryStrategy: { limit: 2 },
},
},
},
Expand Down

0 comments on commit 8022c8d

Please sign in to comment.