-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate Qt plugins deployment #175
Conversation
488aa4b
to
0dd355f
Compare
I have update with my .clang-format but still a bit different, I can manually fix it by hand :(, but I'd rather wait for your review and input about code style :) |
0dd355f
to
80d9946
Compare
This PR is unfortunately not acceptable because one cannot even tell what changes you implemented. You should never just run an autoformatter you like on an entire code base and the PR it. Feel free to fix the PR and provide just the changes you want to propose. But, generally, I advise people to open issues first. |
as I said I thought this project had .clang-format, it's a pain to work with projects that don't, and pre-commit just makes sure maintainers don't need to keed pointing to style issues which I have seen you pointing at on another PR. I there was a proper style file I could just rebase and the PR would be fine. |
80d9946
to
d00970d
Compare
cc46109
to
efacba7
Compare
@TheAssassin done, I didn't bother to remove the using namespace .. which is not in use anymore, I can remove if you like... |
efacba7
to
245d0bd
Compare
Basically, most deployers had the same code that I moved into |
b195c7c
to
779d489
Compare
779d489
to
e50841a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of having both deploy
and doDeploy
(and I think the "deployStandard" name is a bit misleading), but these things tend to happen during refactorings. It's not really a problem. Looks good to me. I can work with these changes!
In the next iteration, we may just use templating to generate all the necessary deployers on the fly and further reduce the amount of code.
Please note that I just ran a quick smoke test. We need to be prepared for incoming issues.
Thank you so much!
e50841a
to
df21c2e
Compare
Build failure is due to a change in the upstream runtime repo. Fixing this on master, rebasing afterwards. |
df21c2e
to
974a64e
Compare
Sorry I added pre-commit locally to make sure clang-format was run and apparently your sources were not in sync with it