Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tailing "/" , target is a file instead of directory #184

Closed
KjellMorgenstern opened this issue Aug 4, 2024 · 4 comments
Closed

Comments

@KjellMorgenstern
Copy link

When building an AppImage, instead of a 'imageformats' directory I now have a file, with the same size as the libqgif.so.
The same seems to happen for other plugin directories. Instead of directories, there are now files.

drwxr-xr-x 2 kjell kjell    4096 Aug  3 22:49 iconengines
-rwxr-xr-x 1 kjell kjell   48440 Aug  3 22:49 imageformats
-rwxr-xr-x 1 kjell kjell   40920 Aug  3 22:49 platforminputcontexts
drwxr-xr-x 2 kjell kjell    4096 Aug  3 22:49 platforms
drwxr-xr-x 2 kjell kjell    4096 Aug  3 22:49 platformthemes
-rwxr-xr-x 1 kjell kjell  137920 Aug  3 22:49 printsupport
-rwxr-xr-x 1 kjell kjell 1495664 Aug  3 22:49 sqldrivers
-rwxr-xr-x 1 kjell kjell  113216 Aug  3 22:49 tls
drwxr-xr-x 2 kjell kjell    4096 Aug  3 22:49 xcbglintegrations

This started to happen with the continuous linux-deplot-qt release yesterday, about the same time as some changes to handling plugins were commited.

-- Running input plugin: qt --
[qt/stdout] Using qmake: /build/dependencies/qt/6.5.3/gcc_64/bin/qmake
[qt/stderr] linuxdeploy-plugin-qt version 1-alpha (git commit ID 0a29e02), GitHub actions build 174 built on 2024-08-03 00:58:52 UTC

[qt/stdout] Deploying shared library /build/dependencies/qt/6.5.3/gcc_64/plugins/imageformats/libqgif.so (destination: AppDir/usr/plugins/imageformats)

Note the missing trailing "/" after imageformats

@TheAssassin
Copy link
Member

Is this happening with the latest continuous build?

@KjellMorgenstern
Copy link
Author

KjellMorgenstern commented Aug 4, 2024

Yes, with git commit ID 0a29e02

And it does not happen with this version: [qt/stderr] linuxdeploy-plugin-qt version 1-alpha (git commit ID bcd597c)

@KjellMorgenstern
Copy link
Author

KjellMorgenstern commented Aug 4, 2024

Maybe this line needs a "/" behind the pluginName?
if (!appDir.deployLibrary(*i, appDir.path() / "usr/plugins" / pluginName))

@TheAssassin
Copy link
Member

It probably does. Must be related to #175. Would you like to send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants