Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased version of #64 #106

Closed

Conversation

pcahyna
Copy link
Member

@pcahyna pcahyna commented Jun 12, 2020

see #64

@pcahyna pcahyna force-pushed the common-fixes-rebased branch from 8c0d774 to a17c4eb Compare June 15, 2020 18:20
@pcahyna
Copy link
Member Author

pcahyna commented Jun 15, 2020

this fails with "volume 'luks-vdb1' cannot be resized from 4 GiB to 4 GiB".

@pcahyna pcahyna mentioned this pull request Jun 30, 2020
Copy link
Collaborator

@yizhanglinux yizhanglinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
I'm trying to cover this line, could you give me more info about on what condition the device will not be resizeable

@yizhanglinux yizhanglinux requested review from yizhanglinux and removed request for yizhanglinux July 3, 2020 09:46
@yizhanglinux
Copy link
Collaborator

Sorry, closed it by mistake.

@yizhanglinux yizhanglinux reopened this Jul 3, 2020
@pcahyna
Copy link
Member Author

pcahyna commented Jul 3, 2020

@dwlehman @japokorn can you please look at the test failure "volume 'luks-vdb1' cannot be resized from 4 GiB to 4 GiB" and fix the problem, so that @yizhanglinux or others can continue developing tests for problems that this PR is supposed to fix?

@dwlehman
Copy link
Collaborator

dwlehman commented Jul 7, 2020

See #125.

@pcahyna
Copy link
Member Author

pcahyna commented Jul 12, 2020

@dwlehman thanks, closing this PR as it is superseded by #125.

@pcahyna pcahyna closed this Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants