Resize fixes #97
Merged
Resize fixes #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
approved these changes
Jun 11, 2020
|
Are there tests for the bugs that this fixes? Or is it enough to enable the currently disabled tests? |
|
will it fix this problem in rebased #64 : #106 (comment) "volume 'luks-vdb1' cannot be resized from 4 GiB to 4 GiB" ? |
This collects information such as the minimum size for the file system and verifies that the required tools are present.
|
@dwlehman I have a version updated to master, I can rebase the branch if you want. |
|
sorry, I see you already did so |
|
@pcahyna ok to merge? |
|
@dwlehman can you please add a test from https://github.com/pcahyna/storage/tree/resize-fixes ? I was not able to push to your branch. |
Based on @yizhanglinux's code in linux-system-roles#139. Remove a disabled resize test from tests_lvm_errors where it does not belong anymore.
pcahyna
added a commit
to pcahyna/storage
that referenced
this pull request
Aug 21, 2020
With merging of linux-system-roles#97 the error message when resizing a volume to a too large size got changed. Account for that in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should resolve issues with resize -- particularly when the volume has an existing file system.
Still needed: