Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Modify backup task to use the 'copy' module instead of 'shell' #2

Merged
merged 3 commits into from
Jun 11, 2024
Merged

refactor: Modify backup task to use the 'copy' module instead of 'shell' #2

merged 3 commits into from
Jun 11, 2024

Conversation

kyleabenson
Copy link
Contributor

@kyleabenson kyleabenson commented Feb 15, 2018 •
edited by spetrosi
Loading

Enhancement: Use the copy module instead of copying with shell: cp.

Result: This helps to enforce a desired state model and reduces ambiguity on success/failure.

@tyll tyll requested a review from yarda July 12, 2018 06:49
yarda
yarda approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@yarda yarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it seems to work. For the multiple backups maybe it could be reworked by using 'backup' option of the 'copy'.

@pcahyna
Copy link
Member

pcahyna commented Jul 19, 2018

[citest]

@pcahyna
Copy link
Member

pcahyna commented Jul 19, 2018

[citest all]

@pcahyna
Copy link
Member

pcahyna commented Jul 20, 2018

[citest commit:23db8ec]

@pcahyna
Copy link
Member

pcahyna commented Jul 20, 2018

[citest commit:23db8ec41073d7c2138486e4456dc17b7970716e]

@pcahyna
Copy link
Member

pcahyna commented Aug 21, 2018

[citest all]

1 similar comment
@pcahyna
Copy link
Member

pcahyna commented Nov 13, 2018

[citest all]

@richm
Copy link
Contributor

richm commented Oct 11, 2021

[citest pending]

2 similar comments
@richm
Copy link
Contributor

richm commented Oct 11, 2021

[citest pending]

@richm
Copy link
Contributor

richm commented Oct 20, 2021

[citest pending]

@spetrosi spetrosi mentioned this pull request Jun 10, 2024
Closed
@spetrosi spetrosi requested review from richm and spetrosi as code owners June 11, 2024 07:35
@spetrosi
Copy link
Contributor

[citest]

@spetrosi
Copy link
Contributor

spetrosi commented Jun 11, 2024 •
edited
Loading

Sorry for lack of work on this, we lost track of it. I rebased and did some changes, now it's ready to merge.

@spetrosi spetrosi changed the title Modified backup task to use the 'copy' module instead of 'shell'... refactor: Modified backup task to use the 'copy' module instead of 'shell'... Jun 11, 2024
@spetrosi spetrosi force-pushed the kbenson branch 2 times, most recently from 7cab93d to 52c38b3 Compare June 11, 2024 07:55
@kyleabenson @spetrosi
Modified backup task to use the 'copy' module instead of 'shell' by p…
7af941c 
…assing the 'remote_src' option. This helps to enforce a desired state model and reduces ambiguity on success/failure.
@spetrosi
Copy link
Contributor

[citest]

@spetrosi spetrosi changed the title refactor: Modified backup task to use the 'copy' module instead of 'shell'... refactor: Modify backup task to use the 'copy' module instead of 'shell' Jun 11, 2024
richm
richm reviewed Jun 11, 2024
View reviewed changes
tasks/main.yml Outdated Show resolved Hide resolved
richm
richm reviewed Jun 11, 2024
View reviewed changes
tasks/main.yml Outdated Show resolved Hide resolved
richm added 2 commits June 11, 2024 10:08
@richm
remove unnecessary quotes
757e4a5 
remove unnecessary quotes
@richm
use double quotes instead of single
62c7310 
use double quotes instead of single
@richm richm merged commit 8d39604 into linux-system-roles:main Jun 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richm richm richm left review comments

@yarda yarda yarda approved these changes

@spetrosi spetrosi Awaiting requested review from spetrosi spetrosi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kyleabenson @pcahyna @richm @spetrosi @yarda