feat: Make the role work on Debian based systems

[Thulium-Drake]

Enhancement: Make role work on Debian

Reason: I have a few systems that run Debian and I wanted to configure Postfix on them in the same manner as I do RHEL based systems.

Result: Role now works on Debian (note that SELinux and Firewalld are not supported/tested)

Issue Tracker Tickets (Jira or BZ if any):

[spetrosi]

[citest]

[Thulium-Drake]

The CI errors don't seem related to this change?

MSG:

The task includes an option with an undefined variable. The error was: list object has no element 1. list object has no element 1

The error appears to be in '/WORKDIR/git-debian_compatiblet52xohsq/.collection/ansible_collections/fedora/linux_system_roles/roles/postfix/tasks/selinux.yml': line 28, column 11, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:


        - name: Add the smtp related service ports to _postfix_selinux
          ^ here

	to retry, use: --limit @/tmp/tests_default.retry

[spetrosi]

Why is this needed? Does Debian use some other executable?

[Thulium-Drake]

Yes, Debian uses Dash when scripts are run with /bin/sh, and that does not support pipefail as option:

# ls -al $(which sh)
lrwxrwxrwx 1 root root 4 Jan  5  2023 /usr/bin/sh -> dash

[spetrosi]

Actually, this task copies files, and we can use the copy module instead of using shell. There is an old #2 that nobody looked at for years, but it has some good code that would fix this. Can you use it here?

[richm]

Also - if we do want to keep the shell - instead of using a different executable, this is how we solve the pipefail issue with other system roles - https://github.com/linux-system-roles/timesync/blob/main/tests/tests_ntp_provider3.yml#L52-L55 e.g. check if pipefail is a supported option, and set it if it is

[spetrosi]

I am about to merge #2, which will fix the issue with pipefail. This PR now lacks adding compatibility with Debian in meta/main.yml, like in https://github.com/linux-system-roles/ssh/blob/main/meta/main.yml#L18-L23

[Thulium-Drake]

Cool, that will also fix it :)

Shall I close this one then?

[richm]

Will fix by #2 instead