Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server][test] Fix checksum calculation bug in Active/Active Partial Update RMD chunking #723

Merged
merged 8 commits into from
Nov 1, 2023
Merged

[server][test] Fix checksum calculation bug in Active/Active Partial Update RMD chunking #723

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1c3bc88
[server][test] Fix checksum calculation bug in Active/Active Partial …
sixpluszero Oct 31, 2023
2d7159d
Make half of the server running in PT mode
sixpluszero Oct 31, 2023
8403cee
Add unit test
sixpluszero Oct 31, 2023
193f788
Update doc
sixpluszero Oct 31, 2023
f5d47b6
Fix static analysis
sixpluszero Oct 31, 2023
7ea1992
Fix test
sixpluszero Oct 31, 2023
8428681
Fix test config setup order
sixpluszero Oct 31, 2023
3edb423
disable another test
sixpluszero Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .../src/integrationTest/java/com/linkedin/venice/integration/utils/VeniceClusterWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.linkedin.venice.integration.utils;

import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_PLAIN_TABLE_FORMAT_ENABLED;
import static com.linkedin.venice.ConfigKeys.*;
import static com.linkedin.venice.integration.utils.VeniceServerWrapper.CLIENT_CONFIG_FOR_CONSUMER;
import static com.linkedin.venice.integration.utils.VeniceServerWrapper.SERVER_ENABLE_SERVER_ALLOW_LIST;
Expand Down Expand Up @@ -259,6 +260,8 @@ static ServiceProvider<VeniceClusterWrapper> generateService(VeniceClusterCreate
featureProperties.setProperty(ENABLE_GRPC_READ_SERVER, Boolean.toString(options.isGrpcEnabled()));
// Half of servers on each mode, with 1 server clusters aligning with the default (true)
featureProperties.setProperty(STORE_WRITER_BUFFER_AFTER_LEADER_LOGIC_ENABLED, Boolean.toString(i % 2 == 0));
// Half of servers will in PT mode, with 1 server clusters aligning with the default (block based mode)
featureProperties.setProperty(ROCKSDB_PLAIN_TABLE_FORMAT_ENABLED, Boolean.toString(i % 2 == 1));

if (!veniceRouterWrappers.isEmpty()) {
ClientConfig clientConfig = new ClientConfig().setVeniceURL(zkAddress)
Expand Down
9 changes: 9 additions & 0 deletions ...n/src/integrationTest/java/com/linkedin/venice/integration/utils/VeniceServerWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package com.linkedin.venice.integration.utils;

import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_OPTIONS_USE_DIRECT_READS;
import static com.linkedin.davinci.store.rocksdb.RocksDBServerConfig.ROCKSDB_PLAIN_TABLE_FORMAT_ENABLED;
import static com.linkedin.venice.ConfigKeys.ADMIN_PORT;
import static com.linkedin.venice.ConfigKeys.CLUSTER_DISCOVERY_D2_SERVICE;
import static com.linkedin.venice.ConfigKeys.DATA_BASE_PATH;
Expand Down Expand Up @@ -195,6 +197,8 @@ static StatefulServiceProvider<VeniceServerWrapper> generateService(
boolean ssl = Boolean.parseBoolean(featureProperties.getProperty(SERVER_ENABLE_SSL, "false"));
boolean isAutoJoin = Boolean.parseBoolean(featureProperties.getProperty(SERVER_IS_AUTO_JOIN, "false"));
boolean isGrpcEnabled = Boolean.parseBoolean(featureProperties.getProperty(ENABLE_GRPC_READ_SERVER, "false"));
boolean isPlainTableEnabled =
Boolean.parseBoolean(featureProperties.getProperty(ROCKSDB_PLAIN_TABLE_FORMAT_ENABLED, "false"));
int numGrpcWorkerThreads = Integer.parseInt(
featureProperties.getProperty(
GRPC_SERVER_WORKER_THREAD_COUNT,
Expand Down Expand Up @@ -259,6 +263,11 @@ static StatefulServiceProvider<VeniceServerWrapper> generateService(
serverPropsBuilder.put(GRPC_SERVER_WORKER_THREAD_COUNT, numGrpcWorkerThreads);
}

if (isPlainTableEnabled) {
serverPropsBuilder.put(ROCKSDB_PLAIN_TABLE_FORMAT_ENABLED, true);
serverPropsBuilder.put(ROCKSDB_OPTIONS_USE_DIRECT_READS, false); // Required by PlainTable format
}
sixpluszero marked this conversation as resolved.
Show resolved Hide resolved

// Add additional config from PubSubBrokerWrapper to server.properties iff the key is not already present
Map<String, String> brokerDetails =
PubSubBrokerWrapper.getBrokerDetailsForClients(Collections.singletonList(pubSubBrokerWrapper));
Expand Down
Loading