[server][test] Fix checksum calculation bug in Active/Active Partial Update RMD chunking #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Update RMD chunking
FelixGV
reviewed
Oct 31, 2023
...mmon/src/integrationTest/java/com/linkedin/venice/integration/utils/VeniceServerWrapper.java
Show resolved
Hide resolved
gaojieliu
reviewed
Oct 31, 2023
...inci-client/src/main/java/com/linkedin/davinci/kafka/consumer/PartitionConsumptionState.java
Show resolved
Hide resolved
FelixGV
reviewed
Oct 31, 2023
...mmon/src/integrationTest/java/com/linkedin/venice/integration/utils/VeniceServerWrapper.java
Show resolved
Hide resolved
gaojieliu
reviewed
Oct 31, 2023
...mmon/src/integrationTest/java/com/linkedin/venice/integration/utils/VeniceServerWrapper.java
Outdated
Show resolved
Hide resolved
gaojieliu
previously approved these changes
Oct 31, 2023
gaojieliu
approved these changes
Oct 31, 2023
elijahgrimaldi
pushed a commit
to elijahgrimaldi/venice
that referenced
this pull request
Nov 1, 2023
…Update RMD chunking (linkedin#723) This PR fixes repush failure in A/A partial update store Current checksum calculation will take every PUT message's key, schemaId, value into account. However, RMD chunk as it is also a chunk PUT message and it is calculated in the running checksum, while the expected checksum which iterates the SST file does not contain it (since RMD chunk is put into RMD CF). This is the reason that repush failed on checksum verification. During the investigation, we also found that default integration test config setup is not correct. It enables PlainTable mode by default and disable checksum verification by default, which is not consistent with current production behavior. This PR fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[server][test] Fix checksum calculation bug in Active/Active Partial Update RMD chunking
This PR fixes repush failure in A/A partial update store
Current checksum calculation will take every PUT message's key, schemaId, value into account. However, RMD chunk as it is also a chunk PUT message and it is calculated in the running checksum, while the expected checksum which iterates the SST file does not contain it (since RMD chunk is put into RMD CF). This is the reason that repush failed on checksum verification.
During the investigation, we also found that default integration test config setup is not correct. It enables PlainTable mode by default and disable checksum verification by default, which is not consistent with current production behavior. This PR fixes the issue.
How was this PR tested?
Existing integration test with tweaked default setting.
Does this PR introduce any user-facing changes?