Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Increase test timeout for FC tests after adding compute to them #717

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[test] Increase test timeout for FC tests after adding compute to them #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/integrationTest/java/com/linkedin/venice/fastclient/AvroStoreClientEndToEndTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ public void testFastClientGet(
}
}

@Test(dataProvider = "fastClientHTTPVariantsAndStoreMetadataFetchModes", timeOut = TIME_OUT)
@Test(dataProvider = "fastClientHTTPVariantsAndStoreMetadataFetchModes", timeOut = 2 * TIME_OUT)
public void testFastClientGetWithDifferentHTTPVariants(
ClientTestUtils.FastClientHTTPVariant fastClientHTTPVariant,
StoreMetadataFetchMode storeMetadataFetchMode) throws Exception {
Expand Down
13 changes: 5 additions & 8 deletions ...ntegrationTest/java/com/linkedin/venice/fastclient/utils/AbstractClientEndToEndSetup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,14 +467,11 @@ private void setupDaVinciClientForMetaStore() {
* TODO: Explore to see if we can reuse these for all the tests rather than cleaning it up everytime.
* */
protected void cleanupDaVinciClientForMetaStore() {
if (daVinciClientForMetaStore != null) {
daVinciClientForMetaStore.close();
daVinciClientForMetaStore = null;
}
if (daVinciClientFactory != null) {
daVinciClientFactory.close();
daVinciClientFactory = null;
}
Utils.closeQuietlyWithErrorLogged(daVinciClientForMetaStore);
daVinciClientForMetaStore = null;

Utils.closeQuietlyWithErrorLogged(daVinciClientFactory);
daVinciClientFactory = null;
}

protected AvroGenericStoreClient<String, GenericRecord> getGenericThinClient(MetricsRepository metricsRepository) {
Expand Down