Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Increase test timeout for FC tests after adding compute to them #717

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

nisargthakkar
Copy link
Contributor

@nisargthakkar nisargthakkar commented Oct 26, 2023

Increase test timeout for FC tests after adding compute to them

After adding read-compute support to fast-client (#664) , some FC tests added a "compute" test to them and this caused tests that were close to hitting the timeout now start getting timed out. This commit increases the timeout for one such test that we notice on our internal CI

How was this PR tested?

CI

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@nisargthakkar nisargthakkar marked this pull request as ready for review October 26, 2023 19:16
@nisargthakkar nisargthakkar changed the title [WIP][test] Increase test timeout for FC tests after adding compute to them [test] Increase test timeout for FC tests after adding compute to them Oct 26, 2023
@nisargthakkar nisargthakkar merged commit e2d8009 into linkedin:main Oct 26, 2023
30 checks passed
@nisargthakkar nisargthakkar deleted the increaseTimeoutTest branch October 26, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants