Fix nativeimgutil.ConvertToRaw() #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
force-pushed
the
convert-to-raw
branch
2 times, most recently
from
d55a1a0
to
0819f1d
Compare
|
Thanks, this seems to work, but the output is confusing It should be like |
But this does not work for the raw-to-raw case, which must expand the image as a second step. I think we should keep the same flow since it is simple, easy to follow, and make it easy to verify that the convert was correct before expanding. So I plan to do this:
|
|
Do you plan to update this PR or open a follow-up PR separately ? |
I can update it this weekend. |
- Truncate before copying the data to eliminate the seeks during the copy. This also provides a hint to the file system that can minimize allocations and fragmentation of the file. - Avoid unneeded seeks during copy using WriteAt. This does not improve performance since practically all time is spent on reading from the source image. - Fix zero detection to handle short reads. Previously we would compare the entire buffer which can contain non-zero bytes from the previous read. - Fix write to handle short reads. Previously we would write the entire buffer including data from previous read, corrupting the image. - Fix error message for failed write. Looks like it was copied from the read branch. Signed-off-by: Nir Soffer <[email protected]>
|
@AkihiroSuda new version keeps the same user interface: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncate before copying the data to eliminate the seeks during the
copy. This also provides a hint to the file system that can minimize
allocations and fragmentation of the file.
Avoid unneeded seeks during copy using WriteAt. This does not improve
performance since practically all time is spent on reading from the
source image.
Fix zero detection to handle short reads. Previously we would compare
the entire buffer which can contain non-zero bytes from the previous
read.
Fix write to handle short reads. Previously we would write the entire
buffer including data from previous read, corrupting the image.
Fix error message for failed write. Looks like it was copied from the
read branch.