nativeimgutil: fix making a sparse file #2715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
previously approved these changes
Oct 10, 2024
`os.(*File).Truncate` can be used directly Signed-off-by: Akihiro Suda <[email protected]>
"Expanding to 100GiB" phase was making a non-sparse 100GiB image Fix issue 2713 Signed-off-by: Akihiro Suda <[email protected]>
|
Sorry, I need to do more testing, but ran out of time for today. Will try again tomorrow. It turns out that I was testing on a RAM disk formatted with HFS+, which does not support sparse files (thanks @nirs for pointing me at that possibility). I thought I tested it again with this PR, and that it then worked, but I can no longer reproduce it. Need to retest all scenarios once more. |
Ok, I was obviously confused for that one, as that is not a valid test of creating a sparse image. |
|
We may rather merge: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Expanding to 100GiB" phase was making a non-sparse 100GiB image
FIx #2713