-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for JsonManifestVersionStrategy #1529
Conversation
ed550b5
to
7bd938b
Compare
@wouterSkepp could you please do a pull request against this branch to adjust the asset versioning documentation ? apart from that i think we are ready to merge. |
@dbu I might have overlooked this bundles ability to change formats in my tests. (eg. the original file is a png and the filter reformats it to a .jpg) I'm willing to have a look at this later on but it'll take a while because of vacationing plans. |
thank you for the heads up! then i will refrain from merging until you (or somebody else) has been able to check that use case and possibly adjust this PR to handle it correctly. |
@wouterSkepp do you have time to look into this so we can wrap up the feature? |
@dbu well this took a bit longer than expected. :) When converting images to a new format, the extension did not get changed as I suspected. Aparantly that is default behaviour (for non-versioned assets as well), unless you decorate the resolver with the FormatExtensionResolver? For those cases I've updated the logic, and these now support extension rewriting by the FormatExtensionResolver. |
d10b3c6
to
4b30bdd
Compare
4b30bdd
to
1ec62cd
Compare
thanks a lot for the contribution! |
wrap up #1525