Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JsonManifestVersionStrategy #1529

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

dbu
Copy link
Member

@dbu dbu commented Sep 7, 2023

wrap up #1525

  • Why is JsonManifestVersionStrategy not found by phpstan?
  • Adjust Resources/doc/asset-versioning.rst to document the new functionality
  • Check file format changes @wouterSkepp

@dbu dbu force-pushed the json_manifest_version_strategy_support branch from ed550b5 to 7bd938b Compare September 7, 2023 09:53
@dbu
Copy link
Member Author

dbu commented Sep 7, 2023

@wouterSkepp could you please do a pull request against this branch to adjust the asset versioning documentation ? apart from that i think we are ready to merge.

@wouterSkepp
Copy link
Contributor

wouterSkepp commented Sep 15, 2023

@dbu I might have overlooked this bundles ability to change formats in my tests. (eg. the original file is a png and the filter reformats it to a .jpg)
I just stumbIed across #1198 about it; I've not tested this PR against these cases and I don't think it's handled correctly by my current implementation. (e.g. the filtered jpg still has it's .png extension)

I'm willing to have a look at this later on but it'll take a while because of vacationing plans.

@dbu
Copy link
Member Author

dbu commented Sep 15, 2023

thank you for the heads up! then i will refrain from merging until you (or somebody else) has been able to check that use case and possibly adjust this PR to handle it correctly.

@coveralls
Copy link

coveralls commented Sep 15, 2023

Coverage Status

coverage: 81.835% (-0.2%) from 82.018%
when pulling 1ec62cd on json_manifest_version_strategy_support
into 862d5aa on 2.x.

@dbu
Copy link
Member Author

dbu commented Nov 14, 2023

@wouterSkepp do you have time to look into this so we can wrap up the feature?

@wouterSkepp
Copy link
Contributor

@dbu well this took a bit longer than expected. :)

When converting images to a new format, the extension did not get changed as I suspected. Aparantly that is default behaviour (for non-versioned assets as well), unless you decorate the resolver with the FormatExtensionResolver?

For those cases I've updated the logic, and these now support extension rewriting by the FormatExtensionResolver.

@dbu dbu force-pushed the json_manifest_version_strategy_support branch 2 times, most recently from d10b3c6 to 4b30bdd Compare June 19, 2024 09:31
@dbu dbu force-pushed the json_manifest_version_strategy_support branch from 4b30bdd to 1ec62cd Compare June 19, 2024 09:34
@dbu dbu merged commit 0c95437 into 2.x Jun 19, 2024
24 checks passed
@dbu dbu deleted the json_manifest_version_strategy_support branch June 19, 2024 09:35
@dbu
Copy link
Member Author

dbu commented Jun 19, 2024

thanks a lot for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants