JsonManifestStrategy, support for FormatExtensionResolver #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/skepp/LiipImagineBundle into json_manifest_version_strategy_support
|
thanks a lot for picking this up. there are conflicts (and the diff shows the changes already in #1529). can you squash the commits and rebase on json_manifest_version_strategy_support and solve conflicts? then it will be visible what actually changes in this pull request. |
…manifest_version_strategy_support
wouterSkepp
force-pushed
the
update-versioning-documentation
branch
from
e1f15c4 to
b5b5569
Compare
Thank you, done |
dbu
merged commit 4c911b2
into
liip:json_manifest_version_strategy_support
14 of 16 checks passed
dbu
pushed a commit
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies, this got very stale.
My initial PR that resulted in #1529 was not supporting format changes; If a filter was to convert a jpg to webp, then the versioned asset would still be served with the .jpg extension.
When applying the FormatExtensionResolver, this is now handled. Versioned JSON manifest assets get their extension swapped as well.
I've bumped the target version to 2.13.