poolrpc: convert poolrpc into a go module #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
Aug 20, 2024
go.mod
Outdated
| google.golang.org/grpc v1.59.0 | ||
| google.golang.org/protobuf v1.33.0 | ||
| golang.org/x/sync v0.8.0 | ||
| google.golang.org/grpc v1.64.1 |
There was a problem hiding this comment.
Same question here re the version we choose for google.golang.org/grpc and google.golang.org/protobuf. IMO they should be the same for all projects, as we've had issues with mismatches and updates to new versions before...
There was a problem hiding this comment.
Given that frdrpc depends on GRPC v1.65.0 and protobuf v1.34.2 I bumped to those versions. Also added a new forked hex display (see here: lightninglabs/protobuf-go-hex-display#3). PTAL
bhandras
force-pushed
the
poolrpc-module
branch
from
a6c5184
to
c1cf809
Compare
|
@guggero: review reminder |
bhandras
force-pushed
the
poolrpc-module
branch
from
c1cf809
to
462423d
Compare
guggero
approved these changes
Oct 14, 2024
bhandras
force-pushed
the
poolrpc-module
branch
from
462423d
to
0382f97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit transforms the
poolrpcsubpackage into a versioned module. By doing so, projects that rely solely on the generated RPC code from the proto files will benefit from significantly reduced dependencies during compilation.Pull Request Checklist
used.