-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: convert litrpc into a module #823
Conversation
e83cf65
to
7d2e962
Compare
7d2e962
to
c648dd8
Compare
c648dd8
to
b7fd53d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
|
||
// We want to format raw bytes as hex instead of base64. The forked version | ||
// allows us to specify that as an option. | ||
replace google.golang.org/protobuf => github.com/lightninglabs/protobuf-go-hex-display v1.34.2-hex-display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't make any references to the UseHexForBytes
change in the library here and replace
directives aren't transitive. So we might as well remove this if we wanted to (if you prefer to leave it in for completeness' sake, just ignore this comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately it does not compile without the replace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaah, because another RPC module (loop/pool/faraday) uses it. Okay, never mind then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice nice nice - lgtm!
@@ -21,4 +23,6 @@ | |||
|
|||
# Contributors (Alphabetical Order) | |||
|
|||
* Andras Banki-Horvath | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove extra space 🤓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(dont worry - i'll fix it in an open PR i have)
Tracking issue: #821
Depends on: