Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD-39899 Improvements for Permission's taglib #4515

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ambrinchaudhary
Copy link

@ambrinchaudhary ambrinchaudhary commented Oct 24, 2024

What is this trying to solve

This is part of the story https://liferay.atlassian.net/browse/LPD-35510. This pull includes:

Screenshot 2024-10-23 at 14 17 50
Screenshot 2024-10-23 at 14 18 19

Other places like Blogs, Web Content ... are not affected, because DM is the only one that has de Download permission.

How can I test it

You can go to Content & Data > Documents and Media and add a File Upload or Multiple Files Upload.

Or run npm run playwright -- test -g 'LPD-39898' --reporter list

npm run playwright -- test -g 'LPD-39898' --reporter list --repeat-each=5

> @liferay/[email protected] playwright
> playwright "test" "-g" "LPD-39898" "--reporter" "list" "--repeat-each=5"


Running 5 tests using 1 worker

  ✓  1 [document-library-web] › document-library-web/dmPermissions.spec.ts:22:1 › DM Permissions initial status (27.9s)
  ✓  2 [document-library-web] › document-library-web/dmPermissions.spec.ts:22:1 › DM Permissions initial status (24.9s)
  ✓  3 [document-library-web] › document-library-web/dmPermissions.spec.ts:22:1 › DM Permissions initial status (22.2s)
  ✓  4 [document-library-web] › document-library-web/dmPermissions.spec.ts:22:1 › DM Permissions initial status (35.1s)
  ✓  5 [document-library-web] › document-library-web/dmPermissions.spec.ts:22:1 › DM Permissions initial status (22.7s)

  5 passed (2.5m)

Note: Previously approved in Content Management: liferay-content-management#6028

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ddeb14626d6563c2fd73d3c85c5baa5f1270f95d

Sender Branch:

Branch Name: LPD-39899_Permissions_show_hide_button
Branch GIT ID: ee6094654e40fa60327145677db2def120081472

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@ambrinchaudhary
Copy link
Author

ci:test:relevant

@ambrinchaudhary ambrinchaudhary changed the title LPD-39899 Permission's improvements in DM LPD-39899 Improvements for Permission's taglib Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants