LPD-39899 Permission's improvements in DM #6028

ambrinchaudhary · 2024-10-23T12:30:16Z

Sending here for first review before forwarding to Frontend Infra team.

What is this trying to solve

https://liferay.atlassian.net/browse/LPD-39899 Remove more/hide options button
https://liferay.atlassian.net/browse/LPD-39898 Change label in DM from “Viewable by” to “Viewable and Downloadable by” (only applies to File Upload and Multiple Upload in DM)

Other places like Blogs, Web Content ... are not affected, because DM is the only one that has de Download permission.

How can I test it

Run npm run playwright -- test -g 'LPD-39898' --reporter list

npm run playwright -- test -g 'LPD-39898' --reporter list --repeat-each=5

> @liferay/[email protected] playwright
> playwright "test" "-g" "LPD-39898" "--reporter" "list" "--repeat-each=5"


Running 5 tests using 1 worker

  ✓  1 [document-library-web] › document-library-web/dmPermissions.spec.ts:22:1 › DM Permissions initial status (27.9s)
  ✓  2 [document-library-web] › document-library-web/dmPermissions.spec.ts:22:1 › DM Permissions initial status (24.9s)
  ✓  3 [document-library-web] › document-library-web/dmPermissions.spec.ts:22:1 › DM Permissions initial status (22.2s)
  ✓  4 [document-library-web] › document-library-web/dmPermissions.spec.ts:22:1 › DM Permissions initial status (35.1s)
  ✓  5 [document-library-web] › document-library-web/dmPermissions.spec.ts:22:1 › DM Permissions initial status (22.7s)

  5 passed (2.5m)

liferay-continuous-integration · 2024-10-23T12:30:23Z

CI is automatically triggering the following test suites:

ci:test:sf

liferay-continuous-integration · 2024-10-23T12:35:24Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 75cdfe67b3f03ae0eaaddbcb91187877e279f954

Sender Branch:

Branch Name: LPD-39899_Permissions_show_hide_button
Branch GIT ID: 3d353a72fdce850189e1505253433ad1a1e00e08

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2024-10-23T12:37:48Z

Jenkins Build:test-portal-source-format#6774

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-content-management#6028

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - ambrinchaudhary > liferay-content-management - PR#6028 - 2024-10-23[05:30:33]

Testray Build ID:49830334

Testray Importer:publish-testray-report#25198

boton · 2024-10-23T13:19:23Z

ci:test:content-management-playwright

liferay-continuous-integration · 2024-10-23T14:37:46Z

						<h1>Unable to generate test report.</h1><p>Jenkins encountered the following error while generating test report:</p><pre><code>The following error occurred while executing this line:

/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:2948: Sourced file: inline evaluation of: import com.liferay.jenkins.results.parser.JenkinsResultsParserUtil; . . . '' : Method Invocation JenkinsResultsParserUtil.toJSONObject : at Line: 297 : in file: inline evaluation of: import com.liferay.jenkins.results.parser.JenkinsResultsParserUtil; . . . '' : JenkinsResultsParserUtil .toJSONObject ( JenkinsResultsParserUtil .getLocalURL ( jenkinsJobURL + "/api/json?tree=duration,result,url" ) , false )

Target exception: java.io.IOException: Server returned HTTP response code: 500 for URL: http://test-1-26/job/test-portal-acceptance-pullrequest(master)/14069//api/json?tree=duration%2Cresult%2Curl

Base Branch:

Branch Name: master

Branch GIT ID: 75cdfe67b3f03ae0eaaddbcb91187877e279f954

Job Summary:

Job Link: test-portal-acceptance-pullrequest(master)

For more details click here.

robertoDiaz · 2024-10-23T15:20:27Z

Java part LGTM 👍

ambrinchaudhary · 2024-10-23T15:23:30Z

ci:test:content-management-playwright

liferay-continuous-integration · 2024-10-23T16:39:37Z

❌ ci:test:content-management-playwright - 11 out of 13 jobs passed in 1 hour 3 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1297401_10569

Base Branch:

Branch Name: master
Branch GIT ID: 75cdfe67b3f03ae0eaaddbcb91187877e279f954

Upstream Comparison:

Branch GIT ID: 20c16b763e47400f6e4d7cc1f462a054278d1d4b
Jenkins Build URL: EE Development Acceptance (master) - 940 - 2024-10-22[08:38:15]

ci:test:content-management-playwright - 11 out of 13 jobs PASSED

2 Failed Jobs:

11 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 20c16b7:

playwright-js-tomcat90-mysql57/9/0 - Playwright Report
1. journal-web/journalArticleAutosave.spec.ts
  Info message appears when autosave is failed due to missing required fields
  Translation is removed when using Undo and restored when using Redo
  Undo/Redo buttons work with metadata fields

liferay-continuous-integration · 2024-10-23T16:43:47Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#10569

Jenkins Report:jenkins-report.html

Jenkins Suite:content-management-playwright

Pull Request:liferay-content-management#6028

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:content-management-playwright - ambrinchaudhary > liferay-content-management - PR#6028 - 2024-10-23[08:35:58]

Testray Build ID:49910412

Testray Importer:publish-testray-report#23454

ambrinchaudhary · 2024-10-24T07:17:55Z

Checked the results of ci:test:content-management-playwright. The failures are currently present on our daily routines, so they are not related to this pull. New test added here is passing.

@boton are you ok if I send this to Frontend Infra team?

boton · 2024-10-24T07:33:15Z

@ambrinchaudhary I'm reviewing now 😅

…sets

boton · 2024-10-24T07:59:26Z

I added some changes after chatting with @ambrinchaudhary, test is working :D

boton · 2024-10-24T08:03:02Z

ci:test:sf

ambrinchaudhary · 2024-10-24T08:07:36Z

Thank you for your review @boton. PR submitted to FI: liferay-frontend#4515

liferay-continuous-integration · 2024-10-24T08:09:33Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ddeb14626d6563c2fd73d3c85c5baa5f1270f95d

Sender Branch:

Branch Name: LPD-39899_Permissions_show_hide_button
Branch GIT ID: ee6094654e40fa60327145677db2def120081472

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2024-10-24T08:38:41Z

Jenkins Build:test-portal-source-format#8182

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-content-management#6028

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - ambrinchaudhary > liferay-content-management - PR#6028 - 2024-10-24[01:03:43]

Testray Build ID:50597810

Testray Importer:publish-testray-report#4556

ambrinchaudhary added 5 commits October 22, 2024 11:04

LPD-39899 Remove hide/show options button under FF

ae9a7dd

LPD-39899 Add FF to portal.properties

fcce86c

LPD-39898 Change label when Download permission exists

0f8f2db

LPD-39898 buildLang

4a52824

LPD-39898 Add functional tests to cover both tasks

3d353a7

liferay-content-management added the ⚠ missing tests label Oct 23, 2024

ambrinchaudhary added 🔍 backend review needed 🔍 frontend review needed 🎭️ playwright review needed and removed ⚠ missing tests labels Oct 23, 2024

liferay-continuous-integration added the ci:test:sf - pending label Oct 23, 2024

ambrinchaudhary requested review from boton and robertoDiaz October 23, 2024 12:32

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - pending labels Oct 23, 2024

liferay-continuous-integration added the ci:test:content-management-playwright - pending label Oct 23, 2024

robertoDiaz approved these changes Oct 23, 2024

View reviewed changes

liferay-continuous-integration added ci:test:content-management-playwright - pending ci:test:content-management-playwright - failure and removed ci:test:content-management-playwright - pending labels Oct 23, 2024

LPD-39899 Use the openFieldset util inside method and type used field…

ee60946

…sets

boton approved these changes Oct 24, 2024

View reviewed changes

liferay-continuous-integration added ci:test:sf - pending and removed ci:test:sf - success labels Oct 24, 2024

ambrinchaudhary mentioned this pull request Oct 24, 2024

LPD-39899 Improvements for Permission's taglib liferay-frontend/liferay-portal#4515

Open

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - pending labels Oct 24, 2024

ambrinchaudhary closed this Oct 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPD-39899 Permission's improvements in DM #6028

LPD-39899 Permission's improvements in DM #6028

ambrinchaudhary commented Oct 23, 2024 •

edited

Loading

liferay-continuous-integration commented Oct 23, 2024

liferay-continuous-integration commented Oct 23, 2024

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 23, 2024

boton commented Oct 23, 2024

liferay-continuous-integration commented Oct 23, 2024

robertoDiaz commented Oct 23, 2024

ambrinchaudhary commented Oct 23, 2024

liferay-continuous-integration commented Oct 23, 2024

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

liferay-continuous-integration commented Oct 23, 2024

ambrinchaudhary commented Oct 24, 2024

boton commented Oct 24, 2024

boton commented Oct 24, 2024

boton commented Oct 24, 2024

ambrinchaudhary commented Oct 24, 2024

liferay-continuous-integration commented Oct 24, 2024

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 24, 2024

LPD-39899 Permission's improvements in DM #6028

LPD-39899 Permission's improvements in DM #6028

Conversation

ambrinchaudhary commented Oct 23, 2024 • edited Loading

What is this trying to solve

How can I test it

liferay-continuous-integration commented Oct 23, 2024

liferay-continuous-integration commented Oct 23, 2024

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 23, 2024

boton commented Oct 23, 2024

liferay-continuous-integration commented Oct 23, 2024

Base Branch:

Job Summary:

robertoDiaz commented Oct 23, 2024

ambrinchaudhary commented Oct 23, 2024

liferay-continuous-integration commented Oct 23, 2024

❌ ci:test:content-management-playwright - 11 out of 13 jobs passed in 1 hour 3 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

liferay-continuous-integration commented Oct 23, 2024

ambrinchaudhary commented Oct 24, 2024

boton commented Oct 24, 2024

boton commented Oct 24, 2024

boton commented Oct 24, 2024

ambrinchaudhary commented Oct 24, 2024

liferay-continuous-integration commented Oct 24, 2024

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 24, 2024

ambrinchaudhary commented Oct 23, 2024 •

edited

Loading