-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-39899 Permission's improvements in DM #6028
LPD-39899 Permission's improvements in DM #6028
Conversation
CI is automatically triggering the following test suites:
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-39899_Permissions_show_hide_button 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#6774 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-content-management#6028 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - ambrinchaudhary > liferay-content-management - PR#6028 - 2024-10-23[05:30:33] Testray Build ID:49830334 Testray Importer:publish-testray-report#25198 |
ci:test:content-management-playwright |
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:2948: Sourced file: inline evaluation of: Target exception: java.io.IOException: Server returned HTTP response code: 500 for URL: http://test-1-26/job/test-portal-acceptance-pullrequest(master)/14069//api/json?tree=duration%2Cresult%2Curl Base Branch:Branch Name: master Branch GIT ID: 75cdfe67b3f03ae0eaaddbcb91187877e279f954 Job Summary:Job Link: test-portal-acceptance-pullrequest(master) For more details click here. |
Java part LGTM 👍 |
ci:test:content-management-playwright |
Jenkins Build:test-portal-acceptance-pullrequest(master)#10569 Jenkins Report:jenkins-report.html Jenkins Suite:content-management-playwright Pull Request:liferay-content-management#6028 Testray Routine:EE Pull Request Testray Build:[master] ci:test:content-management-playwright - ambrinchaudhary > liferay-content-management - PR#6028 - 2024-10-23[08:35:58] Testray Build ID:49910412 Testray Importer:publish-testray-report#23454 |
Checked the results of ci:test:content-management-playwright. The failures are currently present on our daily routines, so they are not related to this pull. New test added here is passing. @boton are you ok if I send this to Frontend Infra team? |
@ambrinchaudhary I'm reviewing now 😅 |
I added some changes after chatting with @ambrinchaudhary, test is working :D |
ci:test:sf |
Thank you for your review @boton. PR submitted to FI: liferay-frontend#4515 |
✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-39899_Permissions_show_hide_button 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#8182 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-content-management#6028 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - ambrinchaudhary > liferay-content-management - PR#6028 - 2024-10-24[01:03:43] Testray Build ID:50597810 Testray Importer:publish-testray-report#4556 |
Sending here for first review before forwarding to Frontend Infra team.
What is this trying to solve
Other places like Blogs, Web Content ... are not affected, because DM is the only one that has de Download permission.
How can I test it
Run
npm run playwright -- test -g 'LPD-39898' --reporter list