-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-168771 - Migrate Role Permission Navigation to Clay Vertical Nav #1108
Conversation
CI is automatically triggering the following test suites:
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-168771-commits 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#6846 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-appsec#1108 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#3484 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#903 Jenkins Report:jenkins-report.html Jenkins Suite:security Pull Request:liferay-appsec#1108 Testray Routine:EE Pull Request Testray Build:[master] ci:test:security - ethib137 > liferay-appsec - PR#1108 - 2023-05-09[10:50:42] Testray Importer:publish-testray-report#1750 |
❌ ci:test:stable - 27 out of 28 jobs passed❌ ci:test:relevant - 74 out of 77 jobs passed in 1 hour 48 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 56ea09f602ee231f3292ead33b58caf70c02a67d ci:test:stable - 27 out of 28 jobs PASSED1 Failed Jobs:
27 Successful Jobs:ci:test:relevant - 74 out of 77 jobs PASSED3 Failed Jobs:
74 Successful Jobs:For more details click here.Failures unique to this pull:
For upstream results, click here. |
Jenkins Build:test-portal-acceptance-pullrequest(master)#902 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-appsec#1108 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - ethib137 > liferay-appsec - PR#1108 - 2023-05-09[10:50:31] Testray Importer:publish-testray-report#1751 |
Hey @john-co at least one test is failing because the test is trying to find an element based on an ID that I removed. Many of the ids and classes are no longer needed since we are using the Clay component, so I don't want to add them there unnecessarily. Can you let me know what elements we would need QA identifiers for, and I can add in |
ci:test:bundle |
✔️ ci:test:bundle - 1 out of 1 jobs passed in 29 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 73ab9bf82e0d38f99fabc6a51416cfe7bc2f07d1 ci:test:bundle - 1 out of 1 jobs PASSEDFor more details click here.Test bundle downloads:
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#11325 Jenkins Report:jenkins-report.html Jenkins Suite:bundle Pull Request:liferay-appsec#1108 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#25079 |
ci:test:roles |
Thanks @ethib137 , for consistency with existing side panel at Widget Pages, at the element with |
Hi @stian-sigvartsen that makes sense. Thanks for your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay on this one @ethib137. Looks good on my end, thanks!
@ethib137 looks good to me also! I will forward. Thanks! |
ci:forward:force |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-168771-commits 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#4569 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-appsec#1108 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#17136 |
All required test suite(s) passed. |
Error has occurred while attempting to forward pull request to |
1 similar comment
Error has occurred while attempting to forward pull request to |
Error has occurred while forwarding pull request to |
Jenkins Build:test-portal-acceptance-pullrequest(master)#6843 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-appsec#1108 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - ethib137 > liferay-appsec - PR#1108 - 2023-06-13[10:02:43] Testray Importer:publish-testray-report#17141 |
Hi @noraszel, I don't see any conflict. Do you mean that I should manually forward the PR to BChan? |
Hi @ethib137, I commented because of the conflict in the |
Manually forwarded to brianchandotcom/pull/136336 |
https://issues.liferay.com/browse/LPS-168771
This PR seeks to solve accessibility issues that relate to the Role Permissions Navigation. Initially we wanted to only update the markup in the jsp, but this resulted in more complexity trying to keep the javascript working that depended on the old markup. As a result it made more sense to move towards the best option of using the Clay Vertical Nav component directly.
What has changed:
This is currently not possible with the Clay component.All panels now open when filtering and when done filtering it reverts back to the initial state when loaded. This makes more sense to me than closing all the panels after filtering.There is an existing bug with the Clay Vertical Nav that causes some children to overlap when multiple levels deep. This will be fixed here.FixedSince this is a larger rewrite I'm asking for additional testing by @john-co to make sure we don't have any regressions.