LPS-168771 - Migrate Role Permission Navigation to Clay Vertical Nav (rebased) #136336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually forwarding because ci:forward fails on liferay-appsec/pull/1108
https://issues.liferay.com/browse/LPS-168771
This PR seeks to solve accessibility issues that relate to the Role Permissions Navigation. Initially we wanted to only update the markup in the jsp, but this resulted in more complexity trying to keep the javascript working that depended on the old markup. As a result it made more sense to move towards the best option of using the Clay Vertical Nav component directly.
What has changed:
This is currently not possible with the Clay component.All panels now open when filtering and when done filtering it reverts back to the initial state when loaded. This makes more sense to me than closing all the panels after filtering.There is an existing bug with the Clay Vertical Nav that causes some children to overlap when multiple levels deep. This will be fixed here.FixedSince this is a larger rewrite I'm asking for additional testing by @john-co to make sure we don't have any regressions.