This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
feat: replace keypair and ursa-optional with node crypto #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use `ursa-optional` to geenrate RSA keypairs in node.js, falling back to `keypair` if compilation of `ursa-optional` failed at install time. Node.js has supported generating RSA keypairs since 10.x so use that instead and remove the `ursa-optional` and `kepair` dependencies. As a bonus it also supports `jwk` format keys everywhere so the `pem-jwk` dep can go too.
achingbrain
commented
Dec 1, 2021
|
|
||
| exports.utils = require('./rsa-utils') | ||
|
|
||
| exports.generateKey = async function (bits) { // eslint-disable-line require-await | ||
| const key = keypair({ bits }) | ||
| const key = await keypair('rsa', { |
There was a problem hiding this comment.
Could use the sync version here, but used the async version seeing as how the function is async anyway.
|
Can put |
|
Now we just need to find a way to work around the RSA encryption thing to take out forge 😭😭 |
vasco-santos
approved these changes
Dec 1, 2021
|
@hugomrdias some thoughts on that here: #220 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
ursa-optionalto geenrate RSA keypairs in node.js, falling back tokeypairif compilation ofursa-optionalfailed at install time.Node.js has supported generating RSA keypairs since 10.x so use that instead and remove the
ursa-optionalandkepairdependencies.As a bonus node 15+ also supports
jwkformat keys everywhere so thepem-jwkdep can go too.BREAKING CHANGE: requires node 15+