This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
feat: replace keypair and ursa-optional with web-crypto for node #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes native module `ursa-optional` and js fallback library `keypair` in favour of using web-crypto which is available in node 15+ Also adds benchmark suite similar to Ed25519: ```console $ node index.js ursa-optional x 323 ops/sec ±2.84% (70 runs sampled) keypair x 55.33 ops/sec ±11.75% (59 runs sampled) node.js web-crypto x 300 ops/sec ±2.29% (74 runs sampled) fastest is ursa-optional ``` BREAKING CHANGE: requires node 15+
|
We have an issue with webcrypto not supporting our RSA algo for encryption, i will find some refs on this tomorrow |
|
Found it |
|
That's interesting, so in the browser we fall back to node-forge for RSA encryption/decryption because it supports PKCS1 padding, which we've hard coded in the node.js version. As it stands this PR will make node do the same thing which will be slower than using Perhaps we could use node crypto for encrypt/decrypt to retain the performance but keypair generation and sign/verify with web crypto? They we can still get rid of the extra deps. |
|
Or just |
|
Superseded by #219 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes native module
ursa-optionaland js fallback librarykeypairin favour of using web-crypto which is available in node 15+Also adds benchmark suite similar to Ed25519:
BREAKING CHANGE: requires node 15+