Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simple lens<>xmtp web integration #401

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Conversation

krzysu
Copy link
Contributor

@krzysu krzysu commented Jun 26, 2023

  • useXmtpClient hook
  • useStartLensConversation hook
  • useEnhanceConversations and useEnhanceConversation hook
  • example inbox implementation using xmtp-react-sdk and new lens/react-web hooks

@height
Copy link

height bot commented Jun 26, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-12212" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

🦋 Changeset detected

Latest commit: a91fc33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@lens-protocol/shared-kernel Minor
@lens-protocol/react-web Minor
@lens-protocol/domain Minor
@lens-protocol/react Minor
@lens-protocol/api-bindings Patch
@lens-protocol/blockchain-bindings Patch
@lens-protocol/client Patch
@lens-protocol/gated-content Patch
@lens-protocol/storage Patch
@lens-protocol/wagmi Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@krzysu krzysu requested a review from cesarenaldi June 26, 2023 16:36
@krzysu krzysu changed the title feat: useXmtpClient hook feat: simple lens<>xmtp web integration Jun 27, 2023
@krzysu krzysu force-pushed the T-12212/xmtp-client-hook branch 2 times, most recently from b2d4d0e to c9f4fab Compare June 27, 2023 14:36
@krzysu krzysu marked this pull request as ready for review June 27, 2023 15:09
@krzysu krzysu force-pushed the T-12212/xmtp-client-hook branch 2 times, most recently from 0aa2c4b to d46efc3 Compare July 3, 2023 14:11
@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ✅ Ready (Inspect) Visit Preview Aug 7, 2023 11:25am

*
* @internal
*/
export function useEnvironmentConfig(): EnvironmentConfig {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I this still needed, search on this PR does not lead to any usage? 🤔

* @internal
*/
export function useActiveWalletController(): ActiveWallet {
const { activeWallet } = useSharedDependencies();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not for now, but wondering if we should just export useSharedDependencies (as @internal).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, maybe not a bad idea

@krzysu
Copy link
Contributor Author

krzysu commented Aug 1, 2023

I've heard that XMTP folks are doing a total overhaul on sending messages with codecs and encoded content right now. And as their react SDK is not released as v1 yet, I will hold this PR from merging till XMTP is ready with a stable release of their sdk.

@krzysu krzysu merged commit fc31f14 into main Aug 7, 2023
1 check passed
@krzysu krzysu deleted the T-12212/xmtp-client-hook branch August 7, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants