code review 2

lens-protocol · Jul 28, 2023 · 08d7e59 · 08d7e59
1 parent b81ff5c
commit 08d7e59
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 26 deletions.
diff --git a/packages/react-web/src/inbox/useXmtpClient.ts b/packages/react-web/src/inbox/useXmtpClient.ts
@@ -2,7 +2,7 @@ import {
  PendingSigningRequestError,
  UserRejectedError,
  WalletConnectionError,
- useActiveWalletController,
+ useActiveWalletInteractor,
  useInboxKeyStorage,
 } from '@lens-protocol/react';
 import { assertError } from '@lens-protocol/shared-kernel';
@@ -57,7 +57,7 @@ export function useXmtpClient(): UseXmtpClientResult {
  const [isLoading, setIsLoading] = useState(false);
  const [error, setError] = useState<UseXmtpClientResult['error']>();
 
- const activeWalletController = useActiveWalletController();
+ const activeWallet = useActiveWalletInteractor();
  const storage = useInboxKeyStorage();
 
  const initializeWithLens = useCallback(
@@ -67,7 +67,7 @@ export function useXmtpClient(): UseXmtpClientResult {
 
  try {
  const existingKeys = await loadKeys(storage);
- const signer = new SignerAdapter(activeWalletController);
+ const signer = new SignerAdapter(activeWallet);
 
  if (existingKeys) {
  const newClient = await initialize({
@@ -97,7 +97,7 @@ export function useXmtpClient(): UseXmtpClientResult {
  setIsLoading(false);
  }
  },
- [activeWalletController, initialize, storage],
+ [activeWallet, initialize, storage],
  );
 
  return {

diff --git a/packages/react/src/experimental/index.ts b/packages/react/src/experimental/index.ts
@@ -1,4 +1,3 @@
-export * from './useActiveWalletController';
+export * from './useActiveWalletInteractor';
 export * from './useApolloClient';
-export * from './useEnvironmentConfig';
 export * from './useInboxKeyStorage';
diff --git a/...experimental/useActiveWalletController.ts → ...experimental/useActiveWalletInteractor.ts b/...experimental/useActiveWalletController.ts → ...experimental/useActiveWalletInteractor.ts
@@ -7,7 +7,7 @@ import { useSharedDependencies } from '../shared';
  *
  * @internal
  */
-export function useActiveWalletController(): ActiveWallet {
+export function useActiveWalletInteractor(): ActiveWallet {
  const { activeWallet } = useSharedDependencies();
 
  return activeWallet;

diff --git a/packages/react/src/experimental/useEnvironmentConfig.ts b/packages/react/src/experimental/useEnvironmentConfig.ts
diff --git a/packages/react/src/profile/useProfile.ts b/packages/react/src/profile/useProfile.ts
@@ -47,8 +47,8 @@ export function useProfile({
  );
 
  const { data, error, loading } = useReadResult(
- useGetProfile({
- ...useLensApolloClient(
+ useGetProfile(
+ useLensApolloClient(
  useActiveProfileAsDefaultObserver({
  variables: useMediaTransformFromConfig(
  useSourcesFromConfig({
@@ -59,7 +59,7 @@ export function useProfile({
  skip,
  }),
  ),
- }),
+ ),
  );
 
  if (loading) {

diff --git a/packages/react/src/profile/useProfiles.ts b/packages/react/src/profile/useProfiles.ts
@@ -99,15 +99,15 @@ export function useProfiles({
  );
 
  return usePaginatedReadResult(
- useGetAllProfiles({
- ...useLensApolloClient(
+ useGetAllProfiles(
+ useLensApolloClient(
  useActiveProfileAsDefaultObserver({
  variables: useMediaTransformFromConfig(
  useSourcesFromConfig({ byHandles, byProfileIds, limit, observerId }),
  ),
  skip,
  }),
  ),
- }),
+ ),
  );
 }