Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/semantic layers #59

Merged
merged 144 commits into from
Dec 6, 2023
Merged

Feature/semantic layers #59

merged 144 commits into from
Dec 6, 2023

Conversation

mktk1117
Copy link
Collaborator

@mktk1117 mktk1117 commented Aug 2, 2023

Large update of adding functionality of having multi-modal layers such as color, semantic or feature layers.

gerni17 and others added 30 commits October 18, 2022 19:53
… the code yet as it would be hard to recognize the canges
…d workflow embedded in the elevation map is still inside but commented and I started to document the functions and I integrated the first tests
… feature extractor, additionally I added the first tests
…nged a bit the plugin manager to accept different arguments. The datatype has been changed to float32, removed lonomy related files, added a few tests
implemented cpp part for the universal semantic mapping. I did not format  the code yet as it would be hard to review the canges.
@georgflick
Copy link

@mktk1117 Great! I saw that there is some kind of semantic sensor package in the code. Does that mean, the software can then extract the colors (rbg) from the camera image and match / fuse it with the corresponding cell from the elevation map? or how does it work? Thanks.

@mktk1117
Copy link
Collaborator Author

mktk1117 commented Aug 3, 2023

Yes, we now added the functionality of raycasting the single image to the elevation map cells.
We'll have a paper explaining how it works. We'll add the link to the paper once it's ready!

@Becktor
Copy link
Collaborator

Becktor commented Aug 4, 2023

This is cool stuff!

Some assumptions break the point cloud generation for us (we use realsense cameras that use mm instead of m for their depth images) in pointcloud_node.py currently we are just scaling the depth image but this should perhaps be handled by a parameter?

Also on line 251 I'm assuming the 8 should be replaced by a parameter instead of being hardcoded?

Also due to ros_numpy not receiving an update for quite a while, it breaks with newer numpy versions as the np.float attribute no longer exists. A hack is to redefine it after importing numpy np.float=np.float32

I can't add these changes to the pull request but here are some initial bugs/findings

@mktk1117
Copy link
Collaborator Author

mktk1117 commented Aug 9, 2023

Hi Becktor, thanks a lot for your reports!

@mktk1117 mktk1117 merged commit 9a13ec5 into main Dec 6, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants