Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(RingTheory/Polynomial/Hilbert): Polynomial.exists_unique_hilbertPoly and Polynomial.hilbertPoly_mul_one_sub_pow_add #19404

Closed
wants to merge 18 commits into from

Conversation

FMLJohn
Copy link
Collaborator

@FMLJohn FMLJohn commented Nov 23, 2024


Open in Gitpod

In this pull request, the main results we have added are:

  1. Polynomial.exists_unique_hilbertPoly
  2. Polynomial.hilbertPoly_mul_one_sub_pow_add

@FMLJohn FMLJohn added t-algebraic-geometry Algebraic geometry t-algebra Algebra (groups, rings, fields, etc) labels Nov 23, 2024
Copy link

github-actions bot commented Nov 23, 2024

PR summary a99bae1b50

Import changes exceeding 2%

% File
+4.59% Mathlib.RingTheory.Polynomial.HilbertPoly

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.Polynomial.HilbertPoly 1046 1094 +48 (+4.59%)
Import changes for all files
Files Import difference
Mathlib.RingTheory.Polynomial.HilbertPoly 48

Declarations diff

+ exists_unique_hilbertPoly
+ hilbertPoly_mul_one_sub_pow_add
+ hilbertPoly_mul_one_sub_succ
+ invOneSubPow_add
+ one_sub_pow_add_mul_invOneSubPow_val_eq_one_sub_pow
+ one_sub_pow_mul_invOneSubPow_val_add_eq_invOneSubPow_val

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 2, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Dec 2, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 3, 2024
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Dec 3, 2024
@FMLJohn FMLJohn changed the title feat(RingTheory/Polynomial/Hilbert): given a natural number d and a polynomial p : ℤ[X], proved the key property of the Hilbert polynomial in terms of d and p feat(RingTheory/Polynomial/Hilbert): Polynomial.exists_unique_hilbertPoly and Polynomial.hilbertPoly_mul_one_sub_pow_add Dec 4, 2024
@FMLJohn FMLJohn requested a review from kbuzzard December 4, 2024 16:11
@FMLJohn FMLJohn requested a review from jcommelin December 4, 2024 16:11
Mathlib/RingTheory/Polynomial/HilbertPoly.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Polynomial/HilbertPoly.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/PowerSeries/WellKnown.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/PowerSeries/WellKnown.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 4, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 4, 2024
…tPoly` and `Polynomial.hilbertPoly_mul_one_sub_pow_add` (#19404)

Co-authored-by: Li <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/Polynomial/Hilbert): Polynomial.exists_unique_hilbertPoly and Polynomial.hilbertPoly_mul_one_sub_pow_add [Merged by Bors] - feat(RingTheory/Polynomial/Hilbert): Polynomial.exists_unique_hilbertPoly and Polynomial.hilbertPoly_mul_one_sub_pow_add Dec 4, 2024
@mathlib-bors mathlib-bors bot closed this Dec 4, 2024
@mathlib-bors mathlib-bors bot deleted the hilbert_property branch December 4, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-algebraic-geometry Algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants