-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CategoryTheory): command that generates instances for MorphismProperty
#18785
base: master
Are you sure you want to change the base?
Conversation
PR summary 9f0a085912Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very cool! Looking forward to using this. I left some small comments on the tests. Since I don't know anything about meta programming, I can't comment on the implementation.
@erdOne Do you think you could already demonstrate how this will be used in mathlib? Or should that wait for a follow up PR? |
It's #18784 |
By the way: I think the CI failure would be fixed by merging master. (Sorry for the inconvenience, that's a one-time effect of a recent change to the script writing the "summary" comment on this PR.) |
…lib4 into erd1/addMorphismPropertyInstances
Co-authored-by: Calle Sönne