Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(AlgebraicGeometry): define integral morphisms #19121

Closed
wants to merge 3 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Nov 16, 2024

also shows that finite = integral + locally of finite type and closed immersion = finte + mono


Open in Gitpod

Copy link

github-actions bot commented Nov 16, 2024

PR summary 2e3396daa1

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.RingHom.Integral 1483 1499 +16 (+1.08%)
Mathlib.AlgebraicGeometry.Morphisms.Finite 1820 1833 +13 (+0.71%)
Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.Morphisms.Finite 13
Mathlib.RingTheory.RingHom.Integral 16
Mathlib.AlgebraicGeometry.Morphisms.Integral 1830

Declarations diff

+ IsIntegralHom
+ _root_.AlgebraicGeometry.IsClosedImmersion.eq_isFinite_inf_mono
+ _root_.AlgebraicGeometry.IsClosedImmersion.iff_isFinite_and_mono
+ eq_inf
+ hasAffineProperty
+ iff_isIntegralHom_and_locallyOfFiniteType
+ instance (priority := 900) [IsFinite f] : IsIntegralHom f
+ instance (priority := 900) [hf : IsFinite f] : LocallyOfFiniteType f
+ instance (priority := 900) {X Y : Scheme} (f : X ⟶ Y) [IsClosedImmersion f] : IsFinite f
+ instance : ContainsIdentities @IsIntegralHom
+ instance : IsMultiplicative @IsIntegralHom
+ instance : IsStableUnderBaseChange @IsIntegralHom
+ instance : IsStableUnderComposition @IsIntegralHom
+ isIntegral_ofLocalizationSpan
- instance (priority := 900) [hf : IsFinite f] : LocallyOfFiniteType f := by

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@erdOne erdOne added the t-algebraic-geometry Algebraic geometry label Nov 16, 2024
@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes label Nov 19, 2024
@chrisflav
Copy link
Collaborator

Thanks!

maintainer merge

@chrisflav chrisflav removed the awaiting-author A reviewer has asked the author a question or requested changes label Nov 19, 2024
Copy link

🚀 Pull request has been placed on the maintainer queue by chrisflav.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 19, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 19, 2024
also shows that finite = integral + locally of finite type and closed immersion = finte + mono



Co-authored-by: Andrew Yang <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 19, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(AlgebraicGeometry): define integral morphisms [Merged by Bors] - feat(AlgebraicGeometry): define integral morphisms Nov 19, 2024
@mathlib-bors mathlib-bors bot closed this Nov 19, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/integralHom branch November 19, 2024 15:21
TobiasLeichtfried pushed a commit that referenced this pull request Nov 21, 2024
also shows that finite = integral + locally of finite type and closed immersion = finte + mono



Co-authored-by: Andrew Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants