-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(AlgebraicGeometry): define integral morphisms #19121
Conversation
PR summary 2e3396daa1
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.RingTheory.RingHom.Integral | 1483 | 1499 | +16 (+1.08%) |
Mathlib.AlgebraicGeometry.Morphisms.Finite | 1820 | 1833 | +13 (+0.71%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.AlgebraicGeometry.Morphisms.Finite |
13 |
Mathlib.RingTheory.RingHom.Integral |
16 |
Mathlib.AlgebraicGeometry.Morphisms.Integral |
1830 |
Declarations diff
+ IsIntegralHom
+ _root_.AlgebraicGeometry.IsClosedImmersion.eq_isFinite_inf_mono
+ _root_.AlgebraicGeometry.IsClosedImmersion.iff_isFinite_and_mono
+ eq_inf
+ hasAffineProperty
+ iff_isIntegralHom_and_locallyOfFiniteType
+ instance (priority := 900) [IsFinite f] : IsIntegralHom f
+ instance (priority := 900) [hf : IsFinite f] : LocallyOfFiniteType f
+ instance (priority := 900) {X Y : Scheme} (f : X ⟶ Y) [IsClosedImmersion f] : IsFinite f
+ instance : ContainsIdentities @IsIntegralHom
+ instance : IsMultiplicative @IsIntegralHom
+ instance : IsStableUnderBaseChange @IsIntegralHom
+ instance : IsStableUnderComposition @IsIntegralHom
+ isIntegral_ofLocalizationSpan
- instance (priority := 900) [hf : IsFinite f] : LocallyOfFiniteType f := by
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Co-authored-by: Christian Merten <[email protected]>
Thanks! maintainer merge |
🚀 Pull request has been placed on the maintainer queue by chrisflav. |
Thanks! bors merge |
also shows that finite = integral + locally of finite type and closed immersion = finte + mono Co-authored-by: Andrew Yang <[email protected]>
Pull request successfully merged into master. Build succeeded: |
also shows that finite = integral + locally of finite type and closed immersion = finte + mono Co-authored-by: Andrew Yang <[email protected]>
also shows that finite = integral + locally of finite type and closed immersion = finte + mono