Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: define PGame.identical PGame.memₗ PGame.memᵣ #17122

Closed
wants to merge 9 commits into from

Conversation

FR-vdash-bot
Copy link
Collaborator


split from #5901

Open in Gitpod

Copy link

github-actions bot commented Sep 25, 2024

PR summary 70db6730f9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Identical
+ Identical.congr_left
+ Identical.congr_right
+ Identical.equiv
+ Identical.ext
+ Identical.ext_iff
+ Identical.ge
+ Identical.le
+ Identical.moveLeft
+ Identical.moveRight
+ Identical.of_equiv
+ Identical.of_fn
+ Identical.refl
+ Identical.rfl
+ Identical.symm
+ Identical.trans
+ identicalSetoid
+ identical_comm
+ identical_iff
+ identical_iff'
+ identical_of_isEmpty
+ instance : IsEquiv PGame (· ≡ ·) := { }
+ instance : IsRefl PGame (· ≡ ·) := ⟨Identical.refl⟩
+ instance : IsSymm PGame (· ≡ ·) := ⟨fun _ _ ↦ Identical.symm⟩
+ instance : IsTrans PGame (· ≡ ·) := ⟨fun _ _ _ ↦ Identical.trans⟩
+ memᵣ
+ memᵣ.congr_left
+ memᵣ.congr_right
+ memᵣ_def
+ memₗ
+ memₗ.congr_left
+ memₗ.congr_right
+ memₗ_def
+ moveLeft_memₗ
+ moveRight_memᵣ

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary

@vihdzp
Copy link
Collaborator

vihdzp commented Sep 25, 2024

Thanks for splitting this up! I was worried the original PR would stay in limbo due to how overarching it was.

Copy link
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'm excited to soon have the legendary IGame as a part of Mathlib.

Mathlib/SetTheory/Game/PGame.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Game/PGame.lean Show resolved Hide resolved
Mathlib/SetTheory/Game/PGame.lean Outdated Show resolved Hide resolved
Co-authored-by: Violeta Hernández <[email protected]>
@joneugster joneugster added the t-set-theory Set theory label Sep 30, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 18, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 22, 2024
Mathlib/SetTheory/Game/PGame.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Game/PGame.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Game/PGame.lean Outdated Show resolved Hide resolved
Mathlib/SetTheory/Game/PGame.lean Outdated Show resolved Hide resolved
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes label Nov 12, 2024
@FR-vdash-bot FR-vdash-bot removed the awaiting-author A reviewer has asked the author a question or requested changes label Nov 14, 2024
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@kim-em
Copy link
Contributor

kim-em commented Nov 18, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 18, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: define PGame.identical PGame.memₗ PGame.memᵣ [Merged by Bors] - feat: define PGame.identical PGame.memₗ PGame.memᵣ Nov 18, 2024
@mathlib-bors mathlib-bors bot closed this Nov 18, 2024
@mathlib-bors mathlib-bors bot deleted the FR_game_identical_def branch November 18, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-set-theory Set theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants