Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more PGame.identical PGame.memₗ PGame.memᵣ APIs #5901

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

feat: more PGame.identical PGame.memₗ PGame.memᵣ APIs #5901

wants to merge 58 commits into from
+452 −24

Conversation

FR-vdash-bot
Copy link
Collaborator

@FR-vdash-bot FR-vdash-bot commented Jul 14, 2023 •
edited
Loading

This PR is the first step to remove PGame.Relabelling (which is only for implementing things in lean and not real identity) and define games with identity as Eq.

Zulip

Open in Gitpod

(Was a mathlib3 PR)

@FR-vdash-bot
feat: add lemmas about Relator.LeftTotal Relator.RightTotal `Rela…
3cc4bd5 
…tor.BiTotal`
@FR-vdash-bot
feat: define pgame.identical pgame.memₗ pgame.memᵣ
088ac08 
This PR is the first step to remove `PGame.Relabelling` (which is only for implementing things in lean and not real identity) and define games with identity as `Eq`.
@kim-em kim-em added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 14, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 19, 2023
@kim-em kim-em mentioned this pull request Jul 27, 2023
Closed
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 31, 2023
@leanprover-community leanprover-community deleted a comment from kim-em Jul 31, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 31, 2023
@kim-em kim-em added the t-combinatorics Combinatorics label Aug 6, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 31, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 10, 2023
@FR-vdash-bot FR-vdash-bot changed the title feat: define pgame.identical pgame.memₗ pgame.memᵣ feat: define PGame.identical PGame.memₗ PGame.memᵣ Sep 14, 2023
@FR-vdash-bot FR-vdash-bot mentioned this pull request Sep 14, 2023
Open
1 task
@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:24
@FR-vdash-bot FR-vdash-bot changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 11:45
@vihdzp vihdzp added the awaiting-author A reviewer has asked the author a question or requested changes label Aug 21, 2024
@vihdzp
Copy link
Collaborator

vihdzp commented Aug 25, 2024

Are you still available for this PR? If not, I can take it over.

@FR-vdash-bot FR-vdash-bot removed awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Aug 27, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 30, 2024
vihdzp
vihdzp reviewed Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with most of the changes here, and I'd really like this PR to move forward. That being said, I do feel like this PR does more than advertised. There's a bunch of extra golfing, renaming, and some new theorems. Can these be split into separate PRs?

Mathlib/SetTheory/Game/Basic.lean Show resolved Hide resolved
Mathlib/SetTheory/Game/Basic.lean
termination_by (x, y)

/-- `-x * y` and `-(x * y)` have the same moves. -/
lemma neg_mul (x y : PGame) : -x * y ≡ -(x * y) :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the equality in this case too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. (-x * y).LeftMoves = xr × yl ⊕ xl × yr, (-(x * y)).LeftMoves = xl × yr ⊕ xr × yl

@FR-vdash-bot FR-vdash-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 25, 2024
@FR-vdash-bot FR-vdash-bot changed the title feat: define PGame.identical PGame.memₗ PGame.memᵣ feat: add PGame.identical PGame.memₗ PGame.memᵣ APIs Sep 25, 2024
@FR-vdash-bot FR-vdash-bot mentioned this pull request Sep 25, 2024
Closed
@FR-vdash-bot FR-vdash-bot changed the title feat: add PGame.identical PGame.memₗ PGame.memᵣ APIs feat: more PGame.identical PGame.memₗ PGame.memᵣ APIs Sep 25, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Sep 25, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 26, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Nov 18, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vihdzp vihdzp vihdzp left review comments

@hwatheod hwatheod hwatheod left review comments

@urkud urkud urkud left review comments

@timotree3 timotree3 Awaiting requested review from timotree3

Assignees

@kmill kmill

Labels
merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-combinatorics Combinatorics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.