-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue3438 d xdehumidifier #3475
Open
JayHuLBL
wants to merge
110
commits into
master
Choose a base branch
from
issue3438_DXdehumidifier
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
110 commits
Select commit
Hold shift + click to select a range
e0e3f0e
Initial commit
karthikeyad-pnnl 2b514f9
Updated formatting and documentation
karthikeyad-pnnl 9397f8e
Added new files for data record with example values
karthikeyad-pnnl 0299468
Updated reference data used for validation
karthikeyad-pnnl 73da0bb
Updated IDF version to 23.1
karthikeyad-pnnl bb8e3e5
Added tolerance to example and validation models, and validation scripts
karthikeyad-pnnl 82f7a3f
Removed BOM
karthikeyad-pnnl ab64d2b
Removed BOM
karthikeyad-pnnl 2ef619b
Updated package order files
karthikeyad-pnnl d0b7513
Updated unit test results
karthikeyad-pnnl 0fbaefa
Updated experiment setup in validation model
karthikeyad-pnnl 1def939
Updated html tags in documentation
karthikeyad-pnnl de9c52e
Add the unit test results
terrancelu92 125a17d
Merge pull request #76 from terrancelu92/issue3438_DXdehumidifier
karthikeyad-pnnl 388efa7
Removed BOM
karthikeyad-pnnl 13b529b
Addressed comments on PR
karthikeyad-pnnl f4fba78
Removed redundant HTML tags in documentation
karthikeyad-pnnl ce039d1
Addressed inline comments
terrancelu92 1ed2256
Merge pull request #81 from terrancelu92/issue3438_DXdehumidifier
karthikeyad-pnnl 24cc4b6
Merge pull request #3440 from karthikeyad-pnnl/issue3438_DXdehumidifier
JayHuLBL e3c015e
merged master
JayHuLBL 99988f6
added release note
JayHuLBL ca05e58
improved text
JayHuLBL 130b7d8
changed file permission
JayHuLBL 881a45b
Added missing parameter declaration [ci skip]
mwetter 14175b4
reorganized the text
JayHuLBL 06451b2
merged master
JayHuLBL 0c32b32
Merge branch 'master' into issue3438_DXdehumidifier
JayHuLBL 1234e24
Merge branch 'master' into issue3438_DXdehumidifier
JayHuLBL c3f6d2f
Merge branch 'master' into issue3438_DXdehumidifier
JayHuLBL ea83cb9
Change the version to v96
terrancelu92 88800b8
Modify the initialization time for the case
terrancelu92 afc2c52
Add starttime argument to generate the dat file
terrancelu92 08cf375
Add open loop validation case
terrancelu92 c9d8e64
Debug DXDehumidifier open loop testing
terrancelu92 01bcd15
Backing up debugging exercise for DX dehumidifier
karthikeyad-pnnl b4608d6
Added the open loop validation case and enhanced the documentation
terrancelu92 0ef1eaf
Delete the closed loop validation case and add the delay time paramet…
terrancelu92 af24d82
Add results changed from the unit test
terrancelu92 d7e96d1
Removed unused models
karthikeyad-pnnl 0caf1ef
Removed unused mos script
karthikeyad-pnnl fec03e5
Addressed most of comments from Jianjun
terrancelu92 1c7bc98
Replaced html tags with font info with code tags
karthikeyad-pnnl a929e99
Removed redundant if-else condition from equation section. Corrected …
karthikeyad-pnnl 7225577
Simplified equations and calculations for water removal rate and powe…
karthikeyad-pnnl dbf4988
Updated documentation section formatting
karthikeyad-pnnl a5162bd
Added alternative calculation for power consumption using CDL blocks
karthikeyad-pnnl baa5651
Removed redundant calculation blocks
karthikeyad-pnnl 1ab66ba
Updated documentation and formatting
karthikeyad-pnnl 074ead5
Removed unnecessary block
karthikeyad-pnnl db8c336
Merge pull request #3594 from karthikeyad-pnnl/issue3438_DXdehumidifi…
JayHuLBL 4d5897a
corrected html error
JayHuLBL 50ba2b2
improved text documentation
JayHuLBL 6b4b81e
changed the release note
JayHuLBL bd1aabc
changing the record implementation to avoid OMC error
JayHuLBL 0902e59
fixed error when run in OMC [ci skip]
JayHuLBL 5ebed35
upgraded idf file from version 9.6 to 23.1
JayHuLBL e6e3202
Merge branch 'master' into issue3438_DXdehumidifier
JayHuLBL 83ca293
updated .dat file
JayHuLBL 067a736
added unit attribute, corrected defaultComponent specification [ci skip]
JayHuLBL fca9de6
Merge branch 'master' into issue3438_DXdehumidifier
JayHuLBL a885136
merged master
JayHuLBL f17e13b
Merge branch 'master' into issue3438_DXdehumidifier
JayHuLBL 9fd1813
updated reference [ci skip]
JayHuLBL 354cf87
Merge pull request #130 from lbl-srg/issue3438_DXdehumidifier
karthikeyad-pnnl 55140dd
Imported only required changes from #120
karthikeyad-pnnl 18d9e3a
Removed unused class from examples package
karthikeyad-pnnl 365c9df
Moved example data record to the validation package
karthikeyad-pnnl c2d0596
Changed real parameters to SI units. Updated formatting
karthikeyad-pnnl c5d355c
Reverted unnecessary changes to IDF
karthikeyad-pnnl 6a9ae1e
Hardcoded number of coefficients in biquadratic polynomial
karthikeyad-pnnl 3277600
Updated icon layer on curve modifier
karthikeyad-pnnl 711ac0a
Merge pull request #3786 from karthikeyad-pnnl/issue3438_DXdehumidifi…
JayHuLBL 8f6e791
Merge branch 'master' into issue3438_DXdehumidifier
JayHuLBL 50b037c
fixed html errors
JayHuLBL 4f37623
removed empty lines [ci skip]
JayHuLBL 5a7e58f
Removed unused classes and variables
karthikeyad-pnnl 87df70b
Merge remote-tracking branch 'upstream/issue3438_DXdehumidifier' into…
karthikeyad-pnnl 9e95142
Updated unit test results
karthikeyad-pnnl df47287
Merge pull request #3788 from karthikeyad-pnnl/issue3438_DXdehumidifi…
JayHuLBL 5759a99
added reference [ci skip]
JayHuLBL 438b2df
solved conflict [ci skip]
JayHuLBL 5343321
merged master [ci skip]
JayHuLBL 23b57c5
Merge pull request #132 from lbl-srg/issue3438_DXdehumidifier
karthikeyad-pnnl 76cc2c8
Updated name and location of example EnergyPlus data record in Humidi…
karthikeyad-pnnl 0481822
Updated formatting
karthikeyad-pnnl da22a85
Updated formatting
karthikeyad-pnnl 82b7a73
Merge pull request #3799 from karthikeyad-pnnl/issue3438_DXdehumidifi…
JayHuLBL 51fcf0a
Merge branch 'master' into issue3438_DXdehumidifier
JayHuLBL 68d08ac
refactored package order
JayHuLBL a46d350
Merge branch 'issue3438_DXdehumidifier' of https://github.com/lbl-srg…
JayHuLBL ba36717
reversed userGuider package order
JayHuLBL 22b2542
deleted not needed reference, and scripts
JayHuLBL 69c456e
updated energyplus data
JayHuLBL c0836c9
updated reference
JayHuLBL d01ab09
updated released note
JayHuLBL f97437e
added baseclass
JayHuLBL 81e42f6
corrected validation
JayHuLBL b82f20e
corrected package order
JayHuLBL b410be9
updated reference
JayHuLBL 8ce1dfb
Merge branch 'master' into issue3438_DXdehumidifier
JayHuLBL 10323a2
increasse travis run time
JayHuLBL 3b43a6d
deleted PLRtoPulse and modified validation model
JayHuLBL 3da3de6
updated reference
JayHuLBL 2cfa55c
reverted conf file
JayHuLBL 0147776
updated E+ results in Ubuntu 20.04
JayHuLBL 0e66ebf
updated reference
JayHuLBL fca4f4d
updated e+ results with the same python version as in travis
JayHuLBL 26b47f4
updated E+ results with right python and OS
JayHuLBL b7f48af
updated reference
JayHuLBL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
reorganized the text
- Loading branch information
commit 14175b4af236e82bb80a93931ca877495422d0e9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move the
package
instance to be right after theextends