Issue3438 d xdehumidifier #3475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the unit test results
Addressed inline comments
Issue3438 d xdehumidifier
@terrancelu92: I had a quick look and everything seems to be in order. Can you please review the changes and let @JayHuLBL know if all the changes are expected? Thanks! |
|
@karthikeyad-pnnl @terrancelu92 Is it possible to downgrade the IDF file, to 9.6? |
JayHuLBL
commented
Apr 9, 2024
…er_mergeFix Issue3438 d xdehumidifier merge fix
…/modelica-buildings into issue3438_DXdehumidifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #3438.
@karthikeyad-pnnl We are trying to merge the change to master. Would you please take another look to check if the changes are expected?