Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow gem to be installed from source #305

Merged
merged 2 commits into from
Nov 6, 2024

Commits on Nov 5, 2024

  1. Remove unnecessary require "rake"

    This causes an error on bundle install when installing the gem from source.
    
    16.66 [!] There was an error while loading `launchdarkly-server-sdk.gemspec`: cannot load such file -- rake. Bundler cannot continue.
    16.66 
    16.66  #  from /usr/local/bundle/ruby/3.3.0/bundler/gems/ruby-server-sdk-c7080edbad3a/launchdarkly-server-sdk.gemspec:6
    16.66  #  -------------------------------------------
    16.66  #  require "ldclient-rb/version"
    16.66  >  require "rake"
    16.66  #  
    16.66  #  -------------------------------------------
    javierjulio authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    168d4bb View commit details
    Browse the repository at this point in the history
  2. Replace FileList with Dir to fix error

    This causes an error on bundle install when installing the gem from source. FileList comes from Rake but it's unnecessary as Dir is a very common use in popular gemspecs.
    
    [!] There was an error while loading `launchdarkly-server-sdk.gemspec`: uninitialized constant FileList. Bundler cannot continue.
    
     #  from /Users/j.julio/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/bundler/gems/launchdarkly-ruby-server-sdk-b8220416fe3f/launchdarkly-server-sdk.gemspec:18
     #  -------------------------------------------
     #  
     >    spec.files         = FileList["lib/**/*", "README.md", "LICENSE.txt"]
     #    spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
     #  -------------------------------------------
    javierjulio authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    86a31fc View commit details
    Browse the repository at this point in the history