fix: Allow gem to be installed from source #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes an error on bundle install when installing the gem from source. 16.66 [!] There was an error while loading `launchdarkly-server-sdk.gemspec`: cannot load such file -- rake. Bundler cannot continue. 16.66 16.66 # from /usr/local/bundle/ruby/3.3.0/bundler/gems/ruby-server-sdk-c7080edbad3a/launchdarkly-server-sdk.gemspec:6 16.66 # ------------------------------------------- 16.66 # require "ldclient-rb/version" 16.66 > require "rake" 16.66 # 16.66 # -------------------------------------------
This causes an error on bundle install when installing the gem from source. FileList comes from Rake but it's unnecessary as Dir is a very common use in popular gemspecs.
[!] There was an error while loading `launchdarkly-server-sdk.gemspec`: uninitialized constant FileList. Bundler cannot continue.
# from /Users/j.julio/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/bundler/gems/launchdarkly-ruby-server-sdk-b8220416fe3f/launchdarkly-server-sdk.gemspec:18
# -------------------------------------------
#
> spec.files = FileList["lib/**/*", "README.md", "LICENSE.txt"]
# spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
# -------------------------------------------
javierjulio
changed the title
keelerm84
approved these changes
Nov 6, 2024
|
Thank you for your contribution! |
keelerm84
pushed a commit
that referenced
this pull request
Nov 6, 2024
🤖 I have created a release *beep* *boop* --- ## [8.8.2](8.8.1...8.8.2) (2024-11-06) ### Bug Fixes * Allow gem to be installed from source ([#305](#305)) ([76d06bc](76d06bc)) * Improve DataKind eql? to consider object type ([#304](#304)) ([5893245](5893245)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
In #303 I was asked to install the gem in my Gemfile from source to confirm a bug fix but I encountered two
bundle installerrors that prevented that. I had to make these changes to be able to successfully install from source.Describe the solution you've provided
Do not depend on rake in the gemspec as there is no need too. Replacing Rake's
FileListwith Ruby'sDiris a common use for the affected line and can be seen in many popular gemspecs.Describe alternatives you've considered
I didn't consider any alternatives because it would be best to not depend on an unnecessary dependency (e.g. rake) in the gemspec file. This also follows what is commonly done in other Ruby gems so it's well supported.