Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): support public library methods in modules #3308
fix(cli): support public library methods in modules #3308
Changes from 24 commits
f4a22ef
44228a8
fd2cb00
ba71428
98ac5e9
4397e4a
665394c
23ad6cf
8e50101
47fd223
e59d442
2855cdc
df8b52b
d1d4376
7ca8bd0
a4c92b6
f57e8b5
7b05bf0
b8bf3f5
860af17
6605d7a
2cbec49
c9320ed
f1e6e2d
dc5ac42
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe wrap this in a set so if we install multiple ERC20s, we only need to load the libs once?
or ideally, we add support for multiple out dirs in
findLibraries
that can do this automaticallyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah makes sense, I had actually thought of deduplicating but then forgot. Will try it withing findLibraries 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/latticexyz/mud/pull/3321/files
Let me know if this looks good to you 🙏
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.