fix(cli): support public library methods in modules #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dc5ac42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
reviewed
Oct 21, 2024
holic
reviewed
Oct 21, 2024
holic
reviewed
Oct 21, 2024
vdrg
changed the title
vdrg
changed the title
vdrg
force-pushed
the
vdrg/module-libraries
branch
from
4938dfb
to
b223926
Compare
vdrg
force-pushed
the
vdrg/module-libraries
branch
from
7036c55
to
860af17
Compare
vdrg
changed the title
holic
reviewed
Oct 22, 2024
holic
reviewed
Oct 22, 2024
| if (!requirePath) throw new Error("Could not find package.json to import relative to."); | ||
| const require = createRequire(requirePath); | ||
|
|
||
| const moduleOutDirs = config.modules.flatMap((mod) => { |
There was a problem hiding this comment.
maybe wrap this in a set so if we install multiple ERC20s, we only need to load the libs once?
Suggested change
| const moduleOutDirs = config.modules.flatMap((mod) => { | |
| const moduleOutDirs = new Set(config.modules.flatMap((mod) => { |
or ideally, we add support for multiple out dirs in findLibraries that can do this automatically
There was a problem hiding this comment.
ah makes sense, I had actually thought of deduplicating but then forgot. Will try it withing findLibraries 👍
There was a problem hiding this comment.
https://github.com/latticexyz/mud/pull/3321/files
Let me know if this looks good to you 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.