Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add workspace tenancy to provider logs #511

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

geclos
Copy link
Collaborator

@geclos geclos commented Oct 28, 2024

This commit adds a workspace tenancy to provider logs. Since provider logs won't have a mandatory providerId field, we lose the tenancy so we have to add it back with a new workspace_id direct reference.

SET workspace_id = provider_api_keys.workspace_id
FROM provider_api_keys
WHERE provider_logs.provider_id = provider_api_keys.id
AND provider_logs.workspace_id IS NULL;
Copy link
Collaborator Author

@geclos geclos Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update 80k rows which is bordering the limits of what I would do with an sql migration tbh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fucking scary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping us if you want double check

csansoon
csansoon previously approved these changes Oct 28, 2024
@geclos geclos force-pushed the feature/add_workspace_tenancy_to_providerlogs branch from 4d439ea to c8f02d0 Compare October 28, 2024 08:44
@geclos geclos force-pushed the feature/add_workspace_tenancy_to_providerlogs branch 2 times, most recently from ebc20f2 to ec1d5ba Compare October 28, 2024 09:00
This commit adds a workspace tenancy to provider logs. Since provider
logs won't have a mandatory providerId field, we lose the tenancy so we
have to add it back with a new workspace_id direct reference.
@geclos geclos force-pushed the feature/add_workspace_tenancy_to_providerlogs branch from ec1d5ba to f21be7c Compare October 28, 2024 09:02
@geclos geclos merged commit ecde89e into main Oct 28, 2024
3 checks passed
@geclos geclos deleted the feature/add_workspace_tenancy_to_providerlogs branch October 28, 2024 09:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants