Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Fix Typesense search parameters issue #795

Merged

Conversation

karakhanyans
Copy link
Contributor

Fixed the problem with "withSearchParameters" method, removed that method, and used Scout/Builder $options to allow users to add additional options to the query.

@driesvints driesvints changed the title [Typesense] Fix Search Parameters Issue [10.x] Fix Typesense search parameters issue Jan 23, 2024
Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@taylorotwell taylorotwell merged commit 1a89c3d into laravel:10.x Jan 23, 2024
15 checks passed
@taylorotwell
Copy link
Member

@karakhanyans so how should docs be updated?

@karakhanyans
Copy link
Contributor Author

@taylorotwell so instead of

Todo::search('Do grocceries')
->withSearchParameters(['query_by' => 'title, description'])
->get();

It should be

Todo::search('Do grocceries')
->options(['query_by' => 'title, description'])
->get();

@karakhanyans
Copy link
Contributor Author

@taylorotwell created a PR with updated docs here: laravel/docs#9276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants