[Typesense] Fix Search Parameters Issue #794
Conversation
# Conflicts: # src/Engines/TypesenseEngine.php
| /** | ||
| * Create new Typesense engine instance. | ||
| * | ||
| * @param \Typesense $typesense | ||
| * @param Typesense $typesense |
| $this->searchParameters = $options; | ||
|
|
||
| return $this; | ||
| } |
There was a problem hiding this comment.
Removing these methods would imply a breaking change. Are you sure this is the right call? Everyone who is already using Typesense in Scout now will see their implementation break. But we only launched recently so there might still be a window for this.
There was a problem hiding this comment.
The thing is, that these methods are inside the Engine and not accessible from the Builder instance. I can leave them inside Engine, just to not introduce any breaking changes.
There was a problem hiding this comment.
Ah good call. Yeah you can remove them 👍
|
@karakhanyans I'm gonna have to ask you to resend the PR. Seems something went wrong with branching here and lots of old commits are travelling along. Please also see my remarks above. Thanks! |
|
@driesvints did the changes you requested here: #795 |
Fixed the problem with "withSearchParameters" method, removed that method, and used Scout/Builder $options to allow users to add additional options to the query.