-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] dev from opf:dev #120
Commits on Jan 30, 2024
-
Implements the Sync Service for OneDrive
- Adds VCR options for re-recording and filtering sensitive data - Adds error handling to Util.using_admin_token - Improves logging of multiple commands
Configuration menu - View commit details
-
Copy full SHA for 03d5664 - Browse repository at this point
Copy the full SHA 03d5664View commit details
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7025947 - Browse repository at this point
Copy the full SHA 7025947View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b75c7f - Browse repository at this point
Copy the full SHA 6b75c7fView commit details
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6e9fb80 - Browse repository at this point
Copy the full SHA 6e9fb80View commit details -
Generate migration to add
derived_done_ratio
to work packages* Runs `bin/rails generate migration`. * Adds column to `work_packages` and `work_package_journals`. * Backfills column for non leaf work packages.
Configuration menu - View commit details
-
Copy full SHA for 31c2062 - Browse repository at this point
Copy the full SHA 31c2062View commit details -
Add
derived_done_ratio
to the work package base contractI prefer having this explicitly marked as false than having to infer that because of the attribute not being listed, it's non-writable.
Configuration menu - View commit details
-
Copy full SHA for adeafdf - Browse repository at this point
Copy the full SHA adeafdfView commit details -
Add
derived_done_ratio
to the work package schema representerGives the client knowledge of this field in order to pick up on it and render it within forms.
Configuration menu - View commit details
-
Copy full SHA for a331032 - Browse repository at this point
Copy the full SHA a331032View commit details -
Add
derived_done_ratio
to the work package representerReturns the derived_done_ratio in the response when fetching a work package via the API.
Configuration menu - View commit details
-
Copy full SHA for 8db0982 - Browse repository at this point
Copy the full SHA 8db0982View commit details -
Add attribute translation for
derived_done_ratio
Provides the localized name for this field.
Configuration menu - View commit details
-
Copy full SHA for c797810 - Browse repository at this point
Copy the full SHA c797810View commit details -
Add
derivedPercentageDone
to our OAS3 documentationKeeping docs up-to-date.
Configuration menu - View commit details
-
Copy full SHA for 4e728d3 - Browse repository at this point
Copy the full SHA 4e728d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a230f7 - Browse repository at this point
Copy the full SHA 3a230f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c66396 - Browse repository at this point
Copy the full SHA 2c66396View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54fcb02 - Browse repository at this point
Copy the full SHA 54fcb02View commit details -
Fix work package pdf export spec
With the added column to the work packages table, a new page was rendered when exporting the PDF under test. This is a non-functional change and simply situational due to the newly added column. Adapted the expected output to match what is being outputted now by the renderer.
Configuration menu - View commit details
-
Copy full SHA for a67fafd - Browse repository at this point
Copy the full SHA a67fafdView commit details -
Update
derived_done_ratio
on update_ancestores callback* Instead of modifying the `done_ratio` of other work packages in the chain, this commit modifies the `derived_done_ratio` of all relevant work packages in the chain is this is now the value that is derived. * Allows `done_ratio` to be writable as long as the setting allows it. There is no longer a restriction on the work package being a leaf to be writable.
Configuration menu - View commit details
-
Copy full SHA for 02b434e - Browse repository at this point
Copy the full SHA 02b434eView commit details -
Lint
work_packages/update_service_integration_spec
* Runs `bundle exec rubocop -a` on spec file and corrects offenses.
Configuration menu - View commit details
-
Copy full SHA for 107b1ef - Browse repository at this point
Copy the full SHA 107b1efView commit details -
Remove non-null query constraint on derived_done_ratio migrations
* There is no scenario where this column is NULL as the column default is 0.
Configuration menu - View commit details
-
Copy full SHA for 896409f - Browse repository at this point
Copy the full SHA 896409fView commit details -
Use
User.system
instead ofSystem.user
for migration journal user* Ensures the system user is created if it doesn't already exist.
Configuration menu - View commit details
-
Copy full SHA for e5f8002 - Browse repository at this point
Copy the full SHA e5f8002View commit details -
Add schema spec for
derivedPercentageDone
Ensures qualitative properties of the field.
Configuration menu - View commit details
-
Copy full SHA for a7c8729 - Browse repository at this point
Copy the full SHA a7c8729View commit details -
Render derived percentage done only if derivable
If a work package is a leaf, there is no done_ratio to derive. Hence, we'd only like to render the derived_done_ratio if the work package has children in its hierarchy.
Configuration menu - View commit details
-
Copy full SHA for 97682d3 - Browse repository at this point
Copy the full SHA 97682d3View commit details -
Add link to derived done ratio query
Navigates to a query with a view of descendant work packages to inspect the breakdown of child completion.
Configuration menu - View commit details
-
Copy full SHA for 9758e5c - Browse repository at this point
Copy the full SHA 9758e5cView commit details -
Adapt update_ancestors feature spec expectations
We now expect the derived_done_ratio to be updated instead of the parent's own done_ratio.
Configuration menu - View commit details
-
Copy full SHA for 6f2785a - Browse repository at this point
Copy the full SHA 6f2785aView commit details -
Remove
journal_user
definition from migrationCreating activity entries just results in noise and is not being used at the moment as using update_all bypasses Rails hooks.
Configuration menu - View commit details
-
Copy full SHA for 343a89e - Browse repository at this point
Copy the full SHA 343a89eView commit details -
Extract href generator for derived value query
De-duplicates the generation as the links are identical for both DisplayField modules.
Configuration menu - View commit details
-
Copy full SHA for 3abb27e - Browse repository at this point
Copy the full SHA 3abb27eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3242ff7 - Browse repository at this point
Copy the full SHA 3242ff7View commit details -
Revert PDF export spec adaptation
Since the derived % complete is no longer included in the type form configuration, it's no longer included in the pdf export, so the need for adapting the spec in this PR is no longer relevant.
Configuration menu - View commit details
-
Copy full SHA for 63ec4f4 - Browse repository at this point
Copy the full SHA 63ec4f4View commit details
Commits on Feb 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ce01b1f - Browse repository at this point
Copy the full SHA ce01b1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b22a3c - Browse repository at this point
Copy the full SHA 9b22a3cView commit details -
Merge pull request #14599 from opf/implementation/50957-add-derived-d…
…one-ratio-to-work-packages [#51188] Split "% Complete" into a derived-value and self-value
Configuration menu - View commit details
-
Copy full SHA for 3fd6492 - Browse repository at this point
Copy the full SHA 3fd6492View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea1c617 - Browse repository at this point
Copy the full SHA ea1c617View commit details -
Merge pull request #14648 from opf/impl/sharepoint-sync-service
Implements the OneDrive Sync Service
Configuration menu - View commit details
-
Copy full SHA for 16c1253 - Browse repository at this point
Copy the full SHA 16c1253View commit details