Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] dev from opf:dev #120

Merged
merged 31 commits into from
Feb 2, 2024
Merged

[pull] dev from opf:dev #120

merged 31 commits into from
Feb 2, 2024

Commits on Jan 30, 2024

  1. Implements the Sync Service for OneDrive

    - Adds VCR options for re-recording and filtering sensitive data
    - Adds error handling to Util.using_admin_token
    - Improves logging of multiple commands
    mereghost committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    03d5664 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. minor variable renames

    mereghost committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    7025947 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b75c7f View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Configuration menu
    Copy the full SHA
    6e9fb80 View commit details
    Browse the repository at this point in the history
  2. Generate migration to add derived_done_ratio to work packages

    * Runs `bin/rails generate migration`.
    
    * Adds column to `work_packages` and `work_package_journals`.
    
    * Backfills column for non leaf work packages.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    31c2062 View commit details
    Browse the repository at this point in the history
  3. Add derived_done_ratio to the work package base contract

    I prefer having this explicitly marked as false than having to infer
    that because of the attribute not being listed, it's non-writable.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    adeafdf View commit details
    Browse the repository at this point in the history
  4. Add derived_done_ratio to the work package schema representer

    Gives the client knowledge of this field in order to pick up on it
    and render it within forms.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a331032 View commit details
    Browse the repository at this point in the history
  5. Add derived_done_ratio to the work package representer

    Returns the derived_done_ratio in the response when fetching a work
    package via the API.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    8db0982 View commit details
    Browse the repository at this point in the history
  6. Add attribute translation for derived_done_ratio

    Provides the localized name for this field.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c797810 View commit details
    Browse the repository at this point in the history
  7. Add derivedPercentageDone to our OAS3 documentation

    Keeping docs up-to-date.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4e728d3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3a230f7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2c66396 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    54fcb02 View commit details
    Browse the repository at this point in the history
  11. Fix work package pdf export spec

    With the added column to the work packages table, a new page was
    rendered when exporting the PDF under test. This is a non-functional
    change and simply situational due to the newly added column.
    
    Adapted the expected output to match what is being outputted now by
    the renderer.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a67fafd View commit details
    Browse the repository at this point in the history
  12. Update derived_done_ratio on update_ancestores callback

    * Instead of modifying the `done_ratio` of other work packages in the
      chain, this commit modifies the `derived_done_ratio` of all relevant
      work packages in the chain is this is now the value that is derived.
    
    * Allows `done_ratio` to be writable as long as the setting allows it.
      There is no longer a restriction on the work package being a leaf
      to be writable.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    02b434e View commit details
    Browse the repository at this point in the history
  13. Lint work_packages/update_service_integration_spec

    * Runs `bundle exec rubocop -a` on spec file and corrects offenses.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    107b1ef View commit details
    Browse the repository at this point in the history
  14. Remove non-null query constraint on derived_done_ratio migrations

    * There is no scenario where this column is NULL as the column default
      is 0.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    896409f View commit details
    Browse the repository at this point in the history
  15. Use User.system instead of System.user for migration journal user

    * Ensures the system user is created if it doesn't already exist.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e5f8002 View commit details
    Browse the repository at this point in the history
  16. Add schema spec for derivedPercentageDone

    Ensures qualitative properties of the field.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a7c8729 View commit details
    Browse the repository at this point in the history
  17. Render derived percentage done only if derivable

    If a work package is a leaf, there is no done_ratio to derive.
    
    Hence, we'd only like to render the derived_done_ratio if the work
    package has children in its hierarchy.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    97682d3 View commit details
    Browse the repository at this point in the history
  18. Add link to derived done ratio query

    Navigates to a query with a view of descendant work packages to
    inspect the breakdown of child completion.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    9758e5c View commit details
    Browse the repository at this point in the history
  19. Adapt update_ancestors feature spec expectations

    We now expect the derived_done_ratio to be updated instead of the
    parent's own done_ratio.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    6f2785a View commit details
    Browse the repository at this point in the history
  20. Remove journal_user definition from migration

    Creating activity entries just results in noise and is not being used
    at the moment as using update_all bypasses Rails hooks.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    343a89e View commit details
    Browse the repository at this point in the history
  21. Extract href generator for derived value query

    De-duplicates the generation as the links are identical for both
    DisplayField modules.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3abb27e View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    3242ff7 View commit details
    Browse the repository at this point in the history
  23. Revert PDF export spec adaptation

    Since the derived % complete is no longer included in the type form
    configuration, it's no longer included in the pdf export, so the need
    for adapting the spec in this PR is no longer relevant.
    aaron-contreras committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    63ec4f4 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Configuration menu
    Copy the full SHA
    ce01b1f View commit details
    Browse the repository at this point in the history
  2. Remove left over comment

    cbliard committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    9b22a3c View commit details
    Browse the repository at this point in the history
  3. Merge pull request #14599 from opf/implementation/50957-add-derived-d…

    …one-ratio-to-work-packages
    
    [#51188] Split "% Complete" into a derived-value and self-value
    cbliard authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    3fd6492 View commit details
    Browse the repository at this point in the history
  4. Fix flaky specs

    Database can return project children in any order.
    cbliard committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    ea1c617 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #14648 from opf/impl/sharepoint-sync-service

    Implements the OneDrive Sync Service
    mereghost authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    16c1253 View commit details
    Browse the repository at this point in the history