[pull] dev from opf:dev #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
- Adds VCR options for re-recording and filtering sensitive data - Adds error handling to Util.using_admin_token - Improves logging of multiple commands
* Runs `bin/rails generate migration`. * Adds column to `work_packages` and `work_package_journals`. * Backfills column for non leaf work packages.
I prefer having this explicitly marked as false than having to infer that because of the attribute not being listed, it's non-writable.
Gives the client knowledge of this field in order to pick up on it and render it within forms.
Returns the derived_done_ratio in the response when fetching a work package via the API.
Provides the localized name for this field.
Keeping docs up-to-date.
With the added column to the work packages table, a new page was rendered when exporting the PDF under test. This is a non-functional change and simply situational due to the newly added column. Adapted the expected output to match what is being outputted now by the renderer.
* Instead of modifying the `done_ratio` of other work packages in the chain, this commit modifies the `derived_done_ratio` of all relevant work packages in the chain is this is now the value that is derived. * Allows `done_ratio` to be writable as long as the setting allows it. There is no longer a restriction on the work package being a leaf to be writable.
* Runs `bundle exec rubocop -a` on spec file and corrects offenses.
* There is no scenario where this column is NULL as the column default is 0.
* Ensures the system user is created if it doesn't already exist.
Ensures qualitative properties of the field.
If a work package is a leaf, there is no done_ratio to derive. Hence, we'd only like to render the derived_done_ratio if the work package has children in its hierarchy.
Navigates to a query with a view of descendant work packages to inspect the breakdown of child completion.
We now expect the derived_done_ratio to be updated instead of the parent's own done_ratio.
Creating activity entries just results in noise and is not being used at the moment as using update_all bypasses Rails hooks.
De-duplicates the generation as the links are identical for both DisplayField modules.
Since the derived % complete is no longer included in the type form configuration, it's no longer included in the pdf export, so the need for adapting the spec in this PR is no longer relevant.
…one-ratio-to-work-packages [#51188] Split "% Complete" into a derived-value and self-value
Database can return project children in any order.
Implements the OneDrive Sync Service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )